Skip to content

Conversation

@JackTn
Copy link
Member

@JackTn JackTn commented Aug 22, 2025

Copilot AI review requested due to automatic review settings August 22, 2025 06:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the parseSemverVersionString function to improve code organization and remove artificial default values for prerelease properties. The changes extract language-specific conventions into separate functions and reorder variable declarations for better readability.

  • Extracts Python and default conventions into dedicated helper functions
  • Removes artificial default values ('zzz' and '99999999') for prerelease label and number
  • Reorders variable declarations and type definitions for improved organization

@github-actions
Copy link

Hi @JackTn. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 24, 2025
@JackTn
Copy link
Member Author

JackTn commented Oct 27, 2025

@raych1 Is this change necessary?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Oct 27, 2025
@raych1
Copy link
Member

raych1 commented Oct 27, 2025

Nobody has reported the versioning issue, and let's close this for now.

@raych1 raych1 closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants