Skip to content

Feature/change log tools improvement #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Nov 13, 2020
Merged

Feature/change log tools improvement #1153

4 commits merged into from
Nov 13, 2020

Conversation

@chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Oct 29, 2020

Update ChangeLog Logic

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner October 29, 2020 02:45
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 29, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the feature/ChangeLogToolsImprovement branch 2 times, most recently from dcde3b0 to 4e1082a Compare October 29, 2020 21:20
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 29, 2020

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Oct 30, 2020
View reviewed changes
weshaggard
weshaggard reviewed Nov 3, 2020
View reviewed changes
weshaggard
weshaggard reviewed Nov 3, 2020
View reviewed changes
weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
@chidozieononiwu chidozieononiwu force-pushed the feature/ChangeLogToolsImprovement branch 3 times, most recently from 32e4b01 to 9986603 Compare November 10, 2020 17:58
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 10, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the feature/ChangeLogToolsImprovement branch from 9986603 to 3c6091b Compare November 10, 2020 22:50
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 10, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the feature/ChangeLogToolsImprovement branch from 3c6091b to 3b220d0 Compare November 13, 2020 02:39
@chidozieononiwu chidozieononiwu force-pushed the feature/ChangeLogToolsImprovement branch from 3b220d0 to 2fb7985 Compare November 13, 2020 19:24
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 13, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 13, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Nov 13, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e6d24dc into Azure:master Nov 13, 2020
weshaggard
weshaggard reviewed Nov 14, 2020
View reviewed changes
eng/common/scripts/Update-ChangeLog.ps1

if ($ChangeLogEntries.Contains($Version))
{
if ($ChangeLogEntries[$Version].ReleaseStatus -eq $ReleaseStatus)
Copy link
Member

@weshaggard weshaggard Nov 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should set the indention level to 2 spaces like the other ps files.

benbp pushed a commit that referenced this pull request Dec 1, 2020
@chidozieononiwu @benbp
Feature/change log tools improvement (#1153)
b333347 
Update ChangeLog Logic
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@danewalton-msft
update return value of az_iot_message_properties_next (Azure#1153)
ab7417f
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chidozieononiwu @azure-sdk @weshaggard