Skip to content

[perf.yaml] Install .NET from tools repo global.json#11336

Merged
mikeharder merged 5 commits intoAzure:mainfrom
mikeharder:perf-install-dotnet-2
Jul 25, 2025
Merged

[perf.yaml] Install .NET from tools repo global.json#11336
mikeharder merged 5 commits intoAzure:mainfrom
mikeharder:perf-install-dotnet-2

Conversation

@mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 24, 2025 •
edited
Loading

Copilot AI review requested due to automatic review settings July 24, 2025 23:22
@mikeharder mikeharder requested a review from a team as a code owner July 24, 2025 23:22
Copilot AI reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the performance testing pipeline to install .NET SDK using a specific global.json file from the azure-sdk-tools repository instead of using a template-based installation method.

  • Replaces template-based .NET installation with direct UseDotNet@2 task
  • Configures the task to use global.json from azure-sdk-tools/tools/perf-automation/Azure.Sdk.Tools.PerfAutomation directory
  • Adds retry logic for improved reliability

@mikeharder mikeharder requested a review from weshaggard July 24, 2025 23:23
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 24, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 24, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jul 24, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mikeharder mikeharder self-assigned this Jul 25, 2025
@mikeharder mikeharder moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 Jul 25, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 25, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Jul 25, 2025
View reviewed changes
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 25, 2025
@azure-sdk @mikeharder
Sync eng/common directory with azure-sdk-tools for PR 11336 (#35348)
d5b89d3 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11336 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
@mikeharder mikeharder enabled auto-merge (squash) July 25, 2025 05:09
@mikeharder mikeharder merged commit 700b8b8 into Azure:main Jul 25, 2025
7 checks passed
@mikeharder mikeharder deleted the perf-install-dotnet-2 branch July 28, 2025 21:58
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@weshaggard weshaggard weshaggard approved these changes

Assignees

@mikeharder mikeharder

Labels

None yet

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikeharder @azure-sdk @weshaggard