Skip to content

Feature/assign sync p rs #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chidozieononiwu merged 4 commits into from
Oct 16, 2020
Merged

Feature/assign sync p rs #1091

chidozieononiwu merged 4 commits into from
Oct 16, 2020

Conversation

@chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Oct 13, 2020

Get creator of Tools PR
Add the Tools PR creator alias as a reviewer and assignee.
Move logic for adding members (labels, reviewers and assignees) into the eng\common\scripts\Submit-PullRequest.ps1 script.

Replaces #1043

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner October 13, 2020 22:54
@chidozieononiwu chidozieononiwu mentioned this pull request Oct 13, 2020
Closed
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 13, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the feature/AssignSyncPRs branch 2 times, most recently from 38b2e1d to 5732a7e Compare October 14, 2020 02:07
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@mitchdenny
Copy link
Contributor

mitchdenny commented Oct 14, 2020

LGTM

@chidozieononiwu
Copy link
Member Author

chidozieononiwu commented Oct 14, 2020

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 14, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu chidozieononiwu added the EngSys This issue is impacting the engineering system. label Oct 14, 2020
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 14, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu added the Central-EngSys This issue is owned by the Engineering System team. label Oct 14, 2020
@chidozieononiwu chidozieononiwu removed Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Oct 14, 2020
@chidozieononiwu chidozieononiwu requested review from danieljurek and removed request for danieljurek October 14, 2020 20:50
@chidozieononiwu chidozieononiwu added EngSys This issue is impacting the engineering system. and removed EngSys This issue is impacting the engineering system. labels Oct 14, 2020
@chidozieononiwu chidozieononiwu added the Central-EngSys This issue is owned by the Engineering System team. label Oct 15, 2020
@chidozieononiwu chidozieononiwu requested review from danieljurek and removed request for danieljurek October 15, 2020 21:32
@chidozieononiwu chidozieononiwu removed the Central-EngSys This issue is owned by the Engineering System team. label Oct 15, 2020
@chidozieononiwu chidozieononiwu force-pushed the feature/AssignSyncPRs branch 2 times, most recently from f86604d to 6897609 Compare October 15, 2020 21:48
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 15, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 15, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk azure-sdk mentioned this pull request Oct 15, 2020
Merged
weshaggard
weshaggard reviewed Oct 15, 2020
View reviewed changes
eng/common/scripts/Invoke-GitHubAPI.ps1
@@ -1,3 +1,7 @@
if ((Get-ChildItem -Path Function: | ? { $_.Name -eq "LogWarning" }).Count -eq 0) {
Copy link
Member

@weshaggard weshaggard Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What prompted this? Are there any normal cases were we would hit this?

Copy link
Member Author

@chidozieononiwu chidozieononiwu Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gues I can just import it again. This is just for the case where someone is using the script directly and not through common.ps1.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 16, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 16, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Oct 16, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@chidozieononiwu
Copy link
Member Author

chidozieononiwu commented Oct 16, 2020

/check-enforcer override

@chidozieononiwu chidozieononiwu merged commit b1a2e24 into Azure:master Oct 16, 2020
benbp pushed a commit that referenced this pull request Dec 1, 2020
@chidozieononiwu @benbp
Feature/assign sync p rs (#1091)
3fe6c95 
* Refactpr Submit Pull Request Script

* Refactor logic for interacting with Pull Requests

* Rework API Lib

* Remove auto-merge label from sync PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees

@chidozieononiwu chidozieononiwu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chidozieononiwu @azure-sdk @mitchdenny @weshaggard