Update custom Azure pipeline YAML conditions to respect canceled status and remove obsolete CADL files

[Copilot]

This PR updates custom conditions in Azure Pipeline YAML files to properly respect canceled pipeline status and removes obsolete CADL pipeline files that were superseded by TypeSpec equivalents.

Problem

When Azure Pipeline conditions don't explicitly include success/failure state functions, they default to always() behavior, which means steps continue to run even when a pipeline is canceled. This is problematic because:

• Canceled pipelines should stop executing remaining steps
• Resources are wasted on unnecessary execution
• It can interfere with cleanup and cancellation workflows

Additionally, the repository contained obsolete CADL pipeline files that were no longer needed since CADL was renamed to TypeSpec.

Solution

Pipeline Condition Updates

Updated custom conditions in 3 YAML files within eng/pipelines and eng/common/pipelines directories:

apiview-review-gen-typespec.yml - 2 conditions updated:

# BEFORE
condition: eq(variables['Reviews'], '')

# AFTER  
condition: and(succeeded(), eq(variables['Reviews'], ''))

detect-api-changes.yml - 1 condition updated:

# BEFORE
condition: and(${{ parameters.Condition}}, eq(variables['ApiChangeDetectRequestUrl'], ''))

# AFTER
condition: and(succeeded(), ${{ parameters.Condition}}, eq(variables['ApiChangeDetectRequestUrl'], ''))

perf.yml - 1 condition updated:

# BEFORE
condition: ${{ parameters.Profile }}

# AFTER
condition: and(succeeded(), ${{ parameters.Profile }})

File Cleanup

Removed obsolete CADL pipeline files:

• eng/pipelines/apiview-review-gen-cadl.yml
• eng/scripts/Create-Apiview-Token-Cadl.ps1

These files were duplicates of the TypeSpec equivalents and are no longer needed since CADL was renamed to TypeSpec.

Testing

• All modified YAML files validated for syntax correctness
• Changes preserve existing logic while adding required success checks
• Template files with Condition parameters already had proper defaults (succeeded())

Impact

These changes ensure that when pipelines are canceled, steps with custom conditions will properly respect the canceled state and not continue executing unnecessarily. The removal of obsolete CADL files reduces maintenance overhead and eliminates duplicate functionality.

Fixes #10836.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR ensures that custom conditions in Azure Pipeline YAML files properly respect a canceled pipeline state by incorporating succeeded() checks into the conditions.

• Updated conditions in apiview-review-gen-typespec.yml and apiview-review-gen-cadl.yml to include succeeded() with existing checks.
• Updated conditions in detect-api-changes.yml and perf.yml to prepend succeeded() to the conditional expressions.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
eng/pipelines/apiview-review-gen-typespec.yml	Added succeeded() to conditions for Reviews and APIViewURL.
eng/pipelines/apiview-review-gen-cadl.yml	Added succeeded() to conditions for Reviews and APIViewURL.
eng/common/pipelines/templates/steps/detect-api-changes.yml	Prepended succeeded() to the condition to enforce cancellation checks.
eng/common/pipelines/templates/jobs/perf.yml	Prepended succeeded() to the condition for Profile parameter.

[benbp]

LGTM. I checked all other spots and it pretty much got it right and excluded the ones that don't fit.

[benbp]

/azp run azure-sdk-tools - sync - eng-common

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[benbp]

/azp run azure-sdk-tools - sync - eng-common

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[benbp]

/azp run azure-sdk-tools - sync - eng-common

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow