Skip to content

Specify run directory as repo root for mcp runner #10681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benbp merged 1 commit into from
Jun 3, 2025
Merged

Specify run directory as repo root for mcp runner #10681

benbp merged 1 commit into from
Jun 3, 2025

Conversation

@benbp
Copy link
Member

@benbp benbp commented May 16, 2025

Specify run directory as repo root for mcp runner

Copilot AI review requested due to automatic review settings May 16, 2025 23:02
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 16, 2025
@benbp benbp self-assigned this May 16, 2025
@benbp benbp requested a review from a team as a code owner May 16, 2025 23:02
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 16, 2025
@benbp benbp requested a review from scbedd May 16, 2025 23:02
@benbp benbp moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 May 16, 2025
Copilot AI reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mcp runner script to specify the run directory as the repository root.

  • Adds a new parameter $RunDirectory to set the working directory for the process.
  • Modifies the Start-Process invocation to use the specified working directory.

@benbp benbp added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label May 16, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 16, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed May 16, 2025
View reviewed changes
@benbp benbp force-pushed the benbp/mcp-runner-dir branch from aa3a79b to 237b471 Compare May 20, 2025 20:56
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 20, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced May 21, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard reviewed May 21, 2025
View reviewed changes
@benbp benbp force-pushed the benbp/mcp-runner-dir branch from 237b471 to d479041 Compare May 28, 2025 23:22
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 28, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp enabled auto-merge (squash) June 3, 2025 20:13
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 3, 2025
@azure-sdk @benbp
Sync eng/common directory with azure-sdk-tools for PR 10681 (#34492)
1942baa 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#10681 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit 2b74ee5 into main Jun 3, 2025
7 checks passed
@benbp benbp deleted the benbp/mcp-runner-dir branch June 3, 2025 20:19
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@weshaggard weshaggard weshaggard approved these changes

@scbedd scbedd Awaiting requested review from scbedd

Assignees

@benbp benbp

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli Central-EngSys This issue is owned by the Engineering System team.

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benbp @azure-sdk @weshaggard @scbedd