Failed the anchor links with Uppercase. #1062
Conversation
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
Just a few changes from another PR have leaked into this one that need to be tidied up, but otherwise it looks OK to me.
|
/azp list |
|
/azp where |
sima-zhu
force-pushed
the
check_anchor_links
branch
from
8ba6e00 to
2b1a8f5
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
eng/common/scripts/Verify-Links.ps1
Outdated
| return $linkValid | ||
| } | ||
|
|
||
|
|
sima-zhu
dismissed
mitchdenny’s stale review
Have addressed the feedback. No extra feedback from Mitch
|
The following pipelines have been queued for testing: |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1062 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sima-zhu
force-pushed
the
check_anchor_links
branch
from
191f240 to
2151f9d
Compare
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sima-zhu
force-pushed
the
check_anchor_links
branch
from
2151f9d to
d9755fa
Compare
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1062 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)
|
/check-enforcer override |
5 participants
Github io landing page and DocMS both read anchor link with lower case only. Also Doc.MS scan throw warning when we use any upper case anchor links.
Add checking step in Verify-Link script.
Fixed issue: Azure/azure-sdk#1843
Fixed in origin/fix_anchor_tags branch, and triggered the pipelines:
Java: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=577196&view=logs&j=ad792ccc-30b2-59a1-5b53-546a79d88828
.NET: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=577006&view=logs&j=10327055-d4d6-50a6-a312-3d2cd4bd9cb9&t=65f0e4aa-f456-5911-deca-bd807ca3354c
Python: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=577156&view=logs&j=0874ffeb-2919-5b4b-20de-16a97970b94c&t=0874ffeb-2919-5b4b-20de-16a97970b94c
JS: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=577301&view=logs&j=bb87fef4-c233-5bc4-e2df-3e530d70fc4a
C: Azure/azure-sdk-for-c#1433
CPP: Azure/azure-sdk-for-cpp#792
IOS: Azure/azure-sdk-for-ios#490