Merged
Conversation
danieljurek
requested review from
a team,
mitchdenny and
weshaggard
as code owners
This was referenced Sep 21, 2020
mitchdenny
reviewed
Sep 21, 2020
.../Azure.Sdk.Tools.PipelineGenerator/Conventions/WeeklyIntegrationTestingPipelineConvention.cs
Outdated
Show resolved
Hide resolved
Member
|
Looks like you have mixed the pipeline generation changes with the vcpkg work. It is probably best to keep those changes separate. |
Member
|
Looks like the pipeline generation is already part of #1026. |
mitchdenny
previously requested changes
Sep 23, 2020
Contributor
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
Pipeline Generator changes need to be cleaned up.
weshaggard
force-pushed
the
vcpkg-support
branch
from
8c65058 to
146c77a
Compare
Member
|
Updated PR to remove the pipeline generation commit |
ghost
referenced
this pull request
in Azure/azure-sdk-for-net
Sep 24, 2020
Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1031<br> See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)
damirault
dismissed
mitchdenny’s stale review
The pipeline generation code has been removed from this PR.
damirault
approved these changes
Oct 1, 2020
benbp
pushed a commit
that referenced
this pull request
Dec 1, 2020
Co-authored-by: Danny Amirault <dana@microsoft.com>
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.