Merged
Conversation
danieljurek
requested review from
heaths,
mitchdenny and
weshaggard
as code owners
This was referenced Sep 21, 2020
mitchdenny
reviewed
Sep 21, 2020
.../Azure.Sdk.Tools.PipelineGenerator/Conventions/WeeklyIntegrationTestingPipelineConvention.cs
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Sep 21, 2020
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Script changes LGTM, though assigning to $null is faster when performance matters more (just a tip).
mitchdenny
previously requested changes
Sep 23, 2020
Contributor
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
Pipeline Generator changes need to be moved out (you've got it covered in another PR).
weshaggard
force-pushed
the
out-null-deployment
branch
from
cd313ac to
923f168
Compare
Member
|
I updated this PR to remove the pipeline generation changes. |
…e. Logging is not affected.
weshaggard
force-pushed
the
out-null-deployment
branch
from
923f168 to
964d5ac
Compare
Member
|
/check-enforcer reset |
benbp
pushed a commit
that referenced
this pull request
Dec 1, 2020
…e. Logging is not affected. (#1029)
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1028
Example lacking Out-Null (scroll to the bottom of the logs) -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=523905&view=logs&j=b28a1a35-334b-5681-3876-e5562b5e8062&t=ff48ff62-22a8-5437-aae5-18a32a8994ec&l=237
Example with Out-Null (scroll to the bottom of the logs) -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=543132&view=logs&j=b28a1a35-334b-5681-3876-e5562b5e8062&t=85d3da62-e026-56d3-c19c-0f96227fb514&l=160