Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14196#3821

Merged
azure-sdk merged 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196
Mar 4, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14196#3821
azure-sdk merged 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner February 26, 2026 22:35
@azure-sdk azure-sdk requested review from benbp and Copilot February 26, 2026 22:35
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request syncs changes from azure-sdk-tools PR 14196 to the eng/common directory, which contains shared tooling scripts for Azure SDK repositories. The changes add support for cleaning up Azure Storage Sync Services that can block resource group deletion, update the default test subscription, and add warning suppression to subscription selection operations.

Changes:

  • Added a new helper function to remove Storage Sync Services and their dependent resources
  • Updated default test subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME"
  • Added -WarningAction Ignore to Select-AzSubscription calls to suppress warnings

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
eng/common/scripts/Helpers/Resource-Helpers.ps1 Adds Remove-StorageSyncServices function to clean up sync services, sync groups, and endpoints that block resource group deletion
eng/common/TestResources/Update-TestResources.ps1 Updates default subscription ID and adds warning suppression to subscription selection commands
eng/common/TestResources/Remove-TestResources.ps1 Adds Az.Storage and Az.StorageSync module requirements, updates default subscription ID, adds warning suppression, and calls the new Remove-StorageSyncServices function

@azure-sdk azure-sdk merged commit 258002a into main Mar 4, 2026
27 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-benbp/delete-storage-sync-14196 branch March 4, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants