Skip to content

Sync eng/common directory with azure-sdk-tools for PR 13221#3484

Merged
hallipr merged 1 commit intomainfrom
sync-eng/common-add-custom-endpoint-13221
Jan 6, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 13221#3484
hallipr merged 1 commit intomainfrom
sync-eng/common-add-custom-endpoint-13221

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13221 See eng/common workflow

Copilot AI review requested due to automatic review settings January 6, 2026 17:43
@azure-sdk azure-sdk requested a review from a team as a code owner January 6, 2026 17:43
@azure-sdk azure-sdk requested a review from conniey January 6, 2026 17:43
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR 13221, adding support for optional service connection configuration in npm authentication.

Key Changes:

  • Adds a new optional ServiceConnection parameter to the npm authentication template with backward-compatible defaults
  • Enables the npmAuthenticate task to use custom Azure DevOps service connections when specified

@hallipr
Copy link
Member

hallipr commented Jan 6, 2026

Build failures are unrelated to eng/common change

@hallipr hallipr merged commit 5bfd538 into main Jan 6, 2026
25 of 28 checks passed
@hallipr hallipr deleted the sync-eng/common-add-custom-endpoint-13221 branch January 6, 2026 18:43
chlowell pushed a commit that referenced this pull request Jan 16, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13221 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Connie Yau <conniey@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments