[Storage] content_length -> size for PageBlobClient create API#3400
Merged
vincenttran-msft merged 3 commits intoAzure:mainfrom Dec 8, 2025
Merged
[Storage] content_length -> size for PageBlobClient create API#3400vincenttran-msft merged 3 commits intoAzure:mainfrom
content_length -> size for PageBlobClient create API#3400vincenttran-msft merged 3 commits intoAzure:mainfrom
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Storage Blob SDK to align with the latest TypeSpec definitions from azure-rest-api-specs. The primary changes involve renaming parameters for clarity and updating immutability policy-related APIs.
Key changes:
- Renamed
content_length/blob_content_lengthparameters tosizein PageBlobClient'screate()andresize()methods for better clarity - Consolidated
BlobImmutabilityPolicyModeintoImmutabilityPolicyModewith updated serialization format (lowercase) and addedMutablevariant - Updated immutability policy APIs: made
expirya required parameter inset_immutability_policy()and simplified return types toResponse<(), NoFormat>for several blob operations
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob/tsp-location.yaml | Updated commit hash reference to latest TypeSpec definitions |
| sdk/storage/azure_storage_blob/src/models/mod.rs | Removed exports for deleted immutability policy result types and headers |
| sdk/storage/azure_storage_blob/src/generated/models/pub_models.rs | Changed BlobImmutabilityPolicyMode to ImmutabilityPolicyMode and removed obsolete result structs |
| sdk/storage/azure_storage_blob/src/generated/models/method_options.rs | Removed immutability_policy_expiry from options (now a required parameter) |
| sdk/storage/azure_storage_blob/src/generated/models/header_traits.rs | Removed header traits for deleted result types and updated references to ImmutabilityPolicyMode |
| sdk/storage/azure_storage_blob/src/generated/models/enums_serde.rs | Removed serialization code for BlobImmutabilityPolicyMode |
| sdk/storage/azure_storage_blob/src/generated/models/enums_impl.rs | Removed implementation for BlobImmutabilityPolicyMode and updated ImmutabilityPolicyMode with lowercase serialization and Mutable variant |
| sdk/storage/azure_storage_blob/src/generated/models/enums.rs | Removed BlobImmutabilityPolicyMode enum and updated ImmutabilityPolicyMode with Mutable variant |
| sdk/storage/azure_storage_blob/src/generated/clients/page_blob_client.rs | Renamed blob_content_length parameter to size in create() and resize() methods |
| sdk/storage/azure_storage_blob/src/generated/clients/blob_client.rs | Updated immutability policy methods: made expiry required, changed return types to Response<(), NoFormat>, removed documentation for deleted header traits |
| sdk/storage/azure_storage_blob/src/clients/page_blob_client.rs | Updated public wrapper to use size parameter name in create() method |
| sdk/storage/azure_storage_blob/CHANGELOG.md | Added entry for create() parameter rename (incomplete - missing several breaking changes) |
jalauzon-msft
approved these changes
Dec 5, 2025
jalauzon-msft
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title states.
.tsp: Azure/azure-rest-api-specs#39097