Skip to content

Sync eng/common directory with azure-sdk-tools for PR 12867#3339

Merged
JennyPng merged 1 commit intomainfrom
sync-eng/common-update-instr-12867
Nov 13, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 12867#3339
JennyPng merged 1 commit intomainfrom
sync-eng/common-update-instr-12867

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12867 See eng/common workflow

Copilot AI review requested due to automatic review settings November 12, 2025 19:23
@azure-sdk azure-sdk requested a review from a team as a code owner November 12, 2025 19:23
@azure-sdk azure-sdk requested a review from JennyPng November 12, 2025 19:23
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with azure-sdk-tools, specifically updating the verify-setup instructions to change how Python virtual environments are handled.

Key Changes:

  • Shifts from user-prompted venvPath parameter to environment variable-based approach using AZSDKTOOLS_PYTHON_VENV_PATH
  • Removes the requirement to ask users for virtual environment path before running the tool
  • Adds guidance to direct users to the environment variable when Python requirements fail

@JennyPng JennyPng merged commit ed8418c into main Nov 13, 2025
28 checks passed
@JennyPng JennyPng deleted the sync-eng/common-update-instr-12867 branch November 13, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants