[Storage] Make metadata a parameter for set_metadata API, StorageServiceProperties renamed to BlobServiceProperties#2919
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
This is because we renamed <?xml version="1.0" encoding="utf-8"?>
<BlobServiceProperties>
<DefaultServiceVersion>2022-11-02</DefaultServiceVersion>
</BlobServiceProperties>@jhendrixMSFT Is there any way currently to augment what is emitted for this TryFrom implementation? impl TryFrom<BlobServiceProperties> for RequestContent<BlobServiceProperties, XmlFormat> {
type Error = azure_core::Error;
fn try_from(value: BlobServiceProperties) -> Result<Self> {
// RequestContent::try_from(to_xml(&value)?)
// Change to explicitly setting the root tag expected by the service, StorageServiceProperties
RequestContent::try_from(to_xml_with_root("StorageServiceProperties", &value)?)
}
} |
|
You need to use the |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Azure Storage Blob SDK to align with API specification changes, renaming StorageServiceProperties to BlobServiceProperties and modifying the set_metadata API to require metadata as a parameter instead of an optional field.
Key changes:
- Renamed
StorageServicePropertiestoBlobServicePropertiesthroughout the codebase - Updated
set_metadatamethod signature to require metadata as a parameter - Updated TSP specification commit reference
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsp-location.yaml |
Updates commit hash reference for API specification |
blob_service_client.rs (tests) |
Updates test code to use BlobServiceProperties instead of StorageServiceProperties |
blob_container_client.rs (tests) |
Updates test calls to use new set_metadata API signature |
models/mod.rs |
Updates public exports to rename type and remove unused import |
block_blob_client.rs |
Removes unused StorageServiceProperties import |
blob_service_client.rs |
Updates type references in public API methods |
blob_container_client.rs |
Updates set_metadata method signature to require metadata parameter |
sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs
Outdated
Show resolved
Hide resolved
heaths
left a comment
There was a problem hiding this comment.
If the method and/or type shipped in the previous beta, don't forget to update the CHANGELOG.md file.
.tsp: Azure/azure-rest-api-specs#36791