Skip to content

Add SetPackageVersion and GetExistingPackageVersions #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2025
Merged

Add SetPackageVersion and GetExistingPackageVersions #2032

merged 6 commits into from
Jan 31, 2025

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Jan 29, 2025 •
edited
Loading

to support Prepare-Release.ps1

@hallipr hallipr changed the title Add SetPackageVersion and GetExistingPackageVersions to support Prepa… Add SetPackageVersion and GetExistingPackageVersions Jan 29, 2025
heaths
heaths approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing blocking. Just a few questions. Did you run this and see if you get the expected output?

@hallipr hallipr force-pushed the users/pahallis/prepare-release branch from fc4a6d3 to f9a1f66 Compare January 30, 2025 22:26
@hallipr
Copy link
Member Author

hallipr commented Jan 31, 2025

I see nothing blocking. Just a few questions. Did you run this and see if you get the expected output?

I ran Prepare-Release.ps1 with azure_security_keyvault_secrets. It created the package work item and updated the changelog and Cargo.toml correctly. Once in main, we can run it again to submit the changes in a release-prep PR.

@hallipr hallipr merged commit 9927d42 into main Jan 31, 2025
13 checks passed
@hallipr hallipr deleted the users/pahallis/prepare-release branch January 31, 2025 20:07
@hallipr hallipr mentioned this pull request Jan 31, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heaths heaths heaths approved these changes

@RickWinter RickWinter RickWinter approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hallipr @heaths @RickWinter @weshaggard