-
Notifications
You must be signed in to change notification settings - Fork 320
Add Key Vault Keys #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Key Vault Keys #2025
Conversation
|
@jhendrixMSFT has a PR that should be merged soon that'll fix this stuff. |
heaths
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing blocking is that the main.rs file has to be removed or this creates an executable crate.
If you want to test things, I recommend either adding files under examples/ or tests/ (the latter, now that test-proxy work is at MVP).
You only do lib.rs+main.rs if you want to create an executable but with testable functions in lib.rs (you can't test functions in main.rs from outside that module itself).
|
@jhendrixMSFT the breaks are happening because of a bad enum name: Given the "RSA_AES_KEY_WRAP_256" symbol, this should generate "RsaAesKeyWrap256". In Rust, type names (including variants) are PascalCase (what rustc calls "upper camelCase"...shudder) and members, variables, and parameters are snake_case. |
Create initial population of Key Vault Keys