Skip to content

Conversation

@RickWinter
Copy link
Member

Create initial population of Key Vault Keys

@heaths
Copy link
Member

heaths commented Jan 31, 2025

@jhendrixMSFT has a PR that should be merged soon that'll fix this stuff.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing blocking is that the main.rs file has to be removed or this creates an executable crate.

If you want to test things, I recommend either adding files under examples/ or tests/ (the latter, now that test-proxy work is at MVP).

You only do lib.rs+main.rs if you want to create an executable but with testable functions in lib.rs (you can't test functions in main.rs from outside that module itself).

@heaths
Copy link
Member

heaths commented Feb 3, 2025

@jhendrixMSFT the breaks are happening because of a bad enum name:

(RSAAESKEYWRAP_256, "RSA_AES_KEY_WRAP_256")

Given the "RSA_AES_KEY_WRAP_256" symbol, this should generate "RsaAesKeyWrap256". In Rust, type names (including variants) are PascalCase (what rustc calls "upper camelCase"...shudder) and members, variables, and parameters are snake_case.

@RickWinter RickWinter merged commit 6c0095c into Azure:main Feb 4, 2025
16 checks passed
@RickWinter RickWinter deleted the keys branch February 4, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants