set api-version for keyvault list_secrets#1011
Closed
ctaggart wants to merge 1 commit intoAzure:mainfrom
Closed
Conversation
rylev
approved these changes
Aug 16, 2022
|
|
||
| let mut uri = self.client.client.vault_url.clone(); | ||
| uri.set_path("secrets"); | ||
| uri.set_query(Some(API_VERSION_PARAM)); |
Contributor
There was a problem hiding this comment.
Is this the only operation where this is necessary?
Contributor
There was a problem hiding this comment.
It is not. This should be part of the PR I have open for keyvault.
Contributor
|
It would be great if we could get some tests against the mock framework in for keyvault... |
Contributor
|
Going to close this in favor of #962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix. Tested with
cargo run -p azure_security_keyvault --example list_secrets.