Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Change Recovery Services swagger to composite swagger#729

Merged
sarangan12 merged 1 commit into
Azure:masterfrom
sarangan12:ChangeRecoveryServicesToCompositeSwagger
Mar 31, 2017
Merged

Change Recovery Services swagger to composite swagger#729
sarangan12 merged 1 commit into
Azure:masterfrom
sarangan12:ChangeRecoveryServicesToCompositeSwagger

Conversation

@sarangan12
Copy link
Copy Markdown
Contributor

Change Recovery Services swagger to composite swagger.

Ref PR; Azure/azure-rest-api-specs#920

@dsgouda @vishrutshah Please review and approve.

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not merge this PR as discussed offline with @sarangan12

@veronicagg
Copy link
Copy Markdown
Contributor

veronicagg commented Mar 27, 2017

@sarangan12 Changes look good to me. Even though I see the label "non-breaking-changes" I believe this may introduce breaking changes, as the spec changed, so by pointing to the new versions I expect at least namespaces will be different. Thoughts?
@vishrutshah @sarangan12 I'm curious on Vishrut's comment above, could you summarize the offline conversation on why to not merge this one?

@dsgouda
Copy link
Copy Markdown

dsgouda commented Mar 27, 2017

I'm not sure what implications this would have on the ruby sdk but I am quite certain this is a breaking change for C# sdk

@dsgouda
Copy link
Copy Markdown

dsgouda commented Mar 27, 2017

@sarangan12 Please hold off on this PR for now, we ran into some issues with the original PR and we have had to revert it, will post here once we are good to go

@vishrutshah
Copy link
Copy Markdown
Contributor

@sarangan12 Can you please summarize what we discussed here, please.

@dsgouda
Copy link
Copy Markdown

dsgouda commented Mar 30, 2017

@sarangan12 Please merge these changes to appease the changes here Azure/azure-rest-api-specs#1087

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarangan12 sarangan12 merged commit 90b4f83 into Azure:master Mar 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants