Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Changes related to fixing the inheritance logic. #1009

Merged
sarangan12 merged 5 commits into from
Oct 4, 2017
Merged

Changes related to fixing the inheritance logic. #1009

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d52eba5
Changes related to fixing the inheritance logic.
sarangan12 Sep 29, 2017
c51fb8a
PR COmments
sarangan12 Sep 30, 2017
1da4cb1
Minor fix
sarangan12 Oct 2, 2017
ec679a5
Regenerated everything with master version of autorest.ruby
sarangan12 Oct 2, 2017
b38fd86
Added one line of comment
sarangan12 Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions management/azure_mgmt_compute/spec/virtual_machines_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,11 @@
ni = network_client.make_request(:get, ni_path, options)
expect(ni).not_to be_nil
# user NetworkInterface mapper to deserialize object
ni_instance = NetworkInterface.new.from_json(ni)
ni_instance = network_client.deserialize(NetworkInterface.mapper(), ni)
# retrieve first IP address for first IP configuration
ip_address_path = ni_instance.ip_configurations[0].public_ipaddress.id
ip_address = network_client.make_request(:get, ip_address_path, options)
ip_address_instance = PublicIPAddress.new.from_json(ip_address)
ip_address_instance = network_client.deserialize(PublicIPAddress.mapper(), ip_address)

@vishrutshah vishrutshah Sep 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious what has caused this change?

@sarangan12 sarangan12 Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working with David on a different task. It was dropped eventually. This was a remnant from that task

expect(ip_address_instance.dns_settings.fqdn).to eq("testdomain53464.westus.cloudapp.azure.com")
end

Expand All @@ -135,7 +135,7 @@

result = @resource_helper.network_client.network_interfaces.list_all
result.each do |network_interface|
expect(network_interface.virtual_machine).to be_an_instance_of(MsRestAzure::SubResource)
expect(network_interface.virtual_machine).to be_an_instance_of(VirtualMachine)

@vishrutshah vishrutshah Sep 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should have to write Azure::ARM::Compute::Models::VirtualMachine

@sarangan12 sarangan12 Oct 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it should be Azure::ARM::Network::Models::SubResource. The model looks like this:

class NetworkInterface < Resource

      include MsRestAzure

      # @return [SubResource] The reference of a virtual machine.
      attr_accessor :virtual_machine

So, changed it with the latest commit

end
end

Expand Down
1 change: 0 additions & 1 deletion management/azure_mgmt_service_bus/spec/queues_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
namespace_parameters = Azure::ARM::ServiceBus::Models::SBNamespace.new
namespace_parameters.location = 'westus'
queue_parameters = Azure::ARM::ServiceBus::Models::SBQueue.new
queue_parameters.location = 'westus'

@vishrutshah vishrutshah Sep 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for removing this? Just wanted to make sure what has caused this?

@sarangan12 sarangan12 Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because accroding to the Resource definition in ServiceBus queue, there is no location. https://github.com/Azure/azure-rest-api-specs/blob/current/specification/servicebus/resource-manager/Microsoft.ServiceBus/2017-04-01/servicebus.json#L2503


# Create new namespace
namespace = @service_bus_client.namespaces.create_or_update(@resource_group.name, namespace_name, namespace_parameters)
Expand Down