Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/core/azure-core/HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

- Fixed a bug that sends None as request_id #9545
- Enable mypy for customers #9572
- Handle TypeError in deep copy #9620

## 1.2.1 (2020-01-14)

Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/azure/core/pipeline/transport/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def __deepcopy__(self, memo=None):
data = copy.deepcopy(self.body, memo)
files = copy.deepcopy(self.files, memo)
return HttpRequest(self.method, self.url, self.headers, files, data)
except ValueError:
except (ValueError, TypeError):
return copy.copy(self)

@property
Expand Down
13 changes: 13 additions & 0 deletions sdk/core/azure-core/tests/test_universal_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,19 @@ def __deepcopy__(self, memodict={}):
assert request_history.http_request.url == request.url
assert request_history.http_request.method == request.method

def test_request_history_type_error():
class Non_deep_copiable(object):
def __deepcopy__(self, memodict={}):
raise TypeError()

body = Non_deep_copiable()
request = HttpRequest('GET', 'http://127.0.0.1/', {'user-agent': 'test_request_history'})
request.body = body
request_history = RequestHistory(request)
assert request_history.http_request.headers == request.headers
assert request_history.http_request.url == request.url
assert request_history.http_request.method == request.method

@mock.patch('azure.core.pipeline.policies._universal._LOGGER')
def test_no_log(mock_http_logger):
universal_request = HttpRequest('GET', 'http://127.0.0.1/')
Expand Down