Skip to content

Core enable mypy for customers #9577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 10 commits into from
Jan 24, 2020
Merged

Core enable mypy for customers #9577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fd47d0
Revert "Generated from 1f5a1bea9d656db85e7285f259aced9f48278b45 (#9519)"
xiangyan99 Jan 22, 2020
9aa041d
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python
xiangyan99 Jan 22, 2020
5e29dfd
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python
xiangyan99 Jan 22, 2020
12c08ac
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python
xiangyan99 Jan 23, 2020
a81ce2c
add py.typed
xiangyan99 Jan 23, 2020
3b3abfa
remove py.typed for tracing
xiangyan99 Jan 23, 2020
795e093
updates
xiangyan99 Jan 24, 2020
6ece7cc
include py.typed in wheel package
xiangyan99 Jan 24, 2020
84e4a82
fix doc generation
xiangyan99 Jan 24, 2020
f8b1b64
ignore mypy warning (by design)
xiangyan99 Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/core/azure-core/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
### Bug fixes

- Fixed a bug that sends None as request_id #9545
- Enable mypy for customers #9572

## 1.2.1 (2020-01-14)

Expand Down
1 change: 1 addition & 0 deletions sdk/core/azure-core/MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ include *.md
include azure/__init__.py
recursive-include samples *.py *.md
recursive-include doc *.rst
include azure/core/py.typed

Empty file added sdk/core/azure-core/azure/core/py.typed
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions sdk/core/azure-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
setup(
name=PACKAGE_NAME,
version=version,
include_package_data=True,
description='Microsoft Azure {} Library for Python'.format(PACKAGE_PPRINT_NAME),
long_description=readme + '\n\n' + history,
long_description_content_type='text/markdown',
Expand All @@ -61,6 +62,9 @@
# Exclude packages that will be covered by PEP420 or nspkg
'azure',
]),
package_data={
'pytyped': ['py.typed'],
},
install_requires=[
'requests>=2.18.4',
'six>=1.6',
Expand Down
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ def _create_auth(self):
the session.
"""
try:
token_type = self._credential.token_type
# ignore mypy's warning because token_type is Optional
token_type = self._credential.token_type # type: ignore
except AttributeError:
token_type = b"jwt"
if token_type == b"servicebus.windows.net:sastoken":
Expand Down
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/aio/_client_base_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ async def _create_auth_async(self) -> authentication.JWTTokenAsync:

"""
try:
token_type = self._credential.token_type
# ignore mypy's warning because token_type is Optional
token_type = self._credential.token_type # type: ignore
except AttributeError:
token_type = b"jwt"
if token_type == b"servicebus.windows.net:sastoken":
Expand Down