Skip to content

Remove parallel spinner for tox logs. Allow eventhub to run in serial #9428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 1 commit into from
Jan 13, 2020
Merged

Remove parallel spinner for tox logs. Allow eventhub to run in serial #9428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ parameters:
TestMarkArgument: ''
BuildTargetingString: 'azure-*'
TestTimeoutInMinutes: 0
ToxEnvParallel: '--tenvparallel'
TestMatrix:
Linux_Python27:
OSName: 'Linux'
Expand Down Expand Up @@ -117,7 +118,7 @@ jobs:
PythonVersion: $(PythonVersion)
BuildTargetingString: ${{ parameters.BuildTargetingString }}
ToxTestEnv: 'whl,sdist'
ToxEnvParallel: '--tenvparallel'
ToxEnvParallel: ${{ parameters.ToxEnvParallel }}
BeforeTestSteps:
- task: DownloadPipelineArtifact@0
inputs:
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
parameters:
Artifacts: []
ServiceDirectory: not-specified
ToxEnvParallel: '--tenvparallel'

stages:
- stage: Build
jobs:
- template: ../jobs/archetype-sdk-client.yml
parameters:
ServiceDirectory: ${{parameters.ServiceDirectory}}
ToxEnvParallel: ${{parameters.ToxEnvParallel}}

# The Prerelease and Release stages are conditioned on whether we are building a pull request and the branch.
- ${{if and(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.TeamProject'], 'internal'))}}:
Expand Down
1 change: 1 addition & 0 deletions scripts/devops_tasks/tox_harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ def prep_and_run_tox(targeted_packages, parsed_args, options_array=[]):

if in_ci():
replace_dev_reqs(destination_dev_req)
os.environ["TOX_PARALLEL_NO_SPINNER"] = "1"

if parsed_args.tox_env:
tox_execution_array.extend(["-e", parsed_args.tox_env])
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ stages:
- template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: eventhub
ToxEnvParallel: ' '
Copy link
Member

@weshaggard weshaggard Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just a temporary fix until eventhubs can run in parallel? If so I'm fine with this change but we should file an issue for reverting this. If not then I'd like to better understand why we cannot run in parallel.

Copy link
Member Author

@scbedd scbedd Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that. Pretty damn confident that it's not a CI issue, but need to unblock release.

Copy link
Member Author

@scbedd scbedd Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue filed

Artifacts:
- name: azure_eventhub
safeName: azureeventhub
Expand Down