Skip to content

Add delete Directory to share client #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakshith91 merged 2 commits into from
Nov 21, 2019
Merged

Add delete Directory to share client #8764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6167cb5
Add delete direcotry to share client
rakshith91 Nov 21, 2019
e734bb3
change to async dist. trace
rakshith91 Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,3 +659,18 @@ def create_directory(self, directory_name, **kwargs):
kwargs.setdefault('merge_span', True)
directory.create_directory(**kwargs)
return directory # type: ignore

@distributed_trace
def delete_directory(self, directory_name, **kwargs):
# type: (str, Any) -> None
"""Marks the directory for deletion. The directory is
later deleted during garbage collection.

:param str directory_name:
The name of the directory.
:keyword int timeout:
The timeout parameter is expressed in seconds.
:rtype: None
"""
directory = self.get_directory_client(directory_name)
directory.delete_directory(**kwargs)
15 changes: 15 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_share_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,3 +538,18 @@ async def create_directory(self, directory_name, **kwargs):
kwargs.setdefault('merge_span', True)
await directory.create_directory(**kwargs)
return directory # type: ignore

@distributed_trace

@lmazuel lmazuel Nov 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an async decorator

@rakshith91 rakshith91 Nov 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

async def delete_directory(self, directory_name, **kwargs):
# type: (str, Any) -> None
"""Marks the directory for deletion. The directory is
later deleted during garbage collection.

:param str directory_name:
The name of the directory.
:keyword int timeout:
The timeout parameter is expressed in seconds.
:rtype: None
"""
directory = self.get_directory_client(directory_name)
await directory.delete_directory(**kwargs)
Loading