Fix capitalization in the 'Fingerprint' tag for XML of serialization of SSH keys configuration #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of SSH keys configuration
Contributor
|
It's quite possible that the docs have an error. I'll look into the Node.js SDK to see what they do. In any case, I'll add a test case for it. Thanks for your help! |
Contributor
|
Node.js SDK correctly uses the lowercase p: 'Fingerprint'. I filed an issue for the documentation: https://github.com/WindowsAzure/azure-content/issues/1461 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be capitalization typo for the
<Fingerprint/>tag of the SSH keys config serialization.Apparently there is no test for this part of the SDK so I did not update the tests.
However I am not sure whether the error is in the Python SDK or on the server side as the documentation of the API has the same typo.
Without my fix I get a BadRequest complaining about empty or null fingerprint similar to the one reported by this user:
http://social.msdn.microsoft.com/Forums/en-US/WAVirtualMachinesforWindows/thread/8cc8210c-cff2-42b8-a68c-f9df3116e7b2