EventHubs Refactor

[yunhaoling]

• Step1: ripping off EventHubClient, EventHubClientAbstract
• Step2: using uAMQP push model directly

[adxsdk6]

Can one of the admins verify this patch?

[bryevdv]

At least some of the samples do not currently run:

dev ❯ python recv.py
Traceback (most recent call last):
  File "recv.py", line 66, in <module>
    on_error=on_error)
TypeError: receive() missing 1 required positional argument: 'on_event'

At least in this case the proximate issue seems to be a parameter name change on_events -> on_event but then even if I change that, I see:

Partition: 1 met an exception during receiving: object of type 'EventData' has no len()

I would suggest making sure all the samples run before merging this.

Beyond that, I think this is at the stage where it's probably easier to merge the large PR and follow on with more smaller digestible chunks after.

[KieranBrantnerMagee]

Broadly LGTM (for as much detail much as the limited time allowed). The remaining open comments from me are largely nits, so I trust owners to handle reasonably.

Would still sanity check that other reviewers were OK with their resolutions, as I can't speak for them.

[yunhaoling]

Hey @bryevdv, the callback now gives you a single event instead of giving you a list of events.
So len(events) would fail.

There are still API changes that needs to be updated after this refactor PR, so we'd prefer update samples after all the changes has been done.
But there are test codes in the branch which are updated and can serve as samples.

[bryevdv]

There are still API changes that needs to be updated after this refactor PR, so we'd prefer update samples after all the changes has been done.

It's not what I would do (I think change sets should be as "atomic" as possible and working at every PR merge), but in that case I'd suggest making a separate issue at least.

[annatisch]

@bryevdv - Agreed and updated. :)

[annatisch]

/azp run python - eventhubs - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yunhaoling]

/azp run python - eventhubs - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).