Skip to content

Update MSAL dependency #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 5 commits into from
Nov 4, 2019
Merged

Update MSAL dependency #8359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07cc599
update msal
chlowell Nov 1, 2019
81f63fa
update msal-extensions requirement
chlowell Nov 2, 2019
2ea8e44
update history
chlowell Nov 4, 2019
2737797
Merge branch 'release/dec-rollup' into update-msal
chlowell Nov 4, 2019
f62ad7e
this library is no longer in preview
chlowell Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/azure-identity/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

- `ClientCertificateCredential` uses application and tenant IDs correctly
([#8315](https://github.com/Azure/azure-sdk-for-python/pull/8315))
- Adopted msal 1.0.0 and msal-extensions 0.1.3
([8359](https://github.com/Azure/azure-sdk-for-python/pull/8359))


## 1.0.0 (2019-10-29)
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Azure Identity simplifies authentication across the Azure SDK.
It supports token authentication using an Azure Active Directory

This library is in preview and currently supports:
This library currently supports:
- [Service principal authentication](https://docs.microsoft.com/en-us/azure/active-directory/develop/app-objects-and-service-principals)
- [Managed identity authentication](https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/overview)
- User authentication
Expand Down
4 changes: 2 additions & 2 deletions sdk/identity/azure-identity/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
install_requires=[
"azure-core<2.0.0,>=1.0.0",
"cryptography>=2.1.4",
"msal<1.0.0,>=0.4.1",
"msal-extensions~=0.1.2",
"msal<2.0.0,>=1.0.0",
Copy link
Member

@lmazuel lmazuel Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no breaking changes, why not make it msal<2.0.0,>=0.4.1 ? (open question)

Copy link
Member

@lmazuel lmazuel Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complementary question: are we exposing anything from msal to customers? Even thourgh callback or something?

Copy link
Member Author

@chlowell chlowell Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msal 0.4.1 should work but I prefer not to declare support for preview versions now that we've all moved to GA.

Nothing of msal is exposed by design, i.e. any msal in our public API is a bug 😁

Copy link
Member

@johanste johanste Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with setting min version to 1.0.0.

"msal-extensions~=0.1.3",
"six>=1.6",
],
extras_require={
Expand Down
4 changes: 2 additions & 2 deletions shared_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ cryptography>=2.1.4
futures
mock
typing
msal<1.0.0,>=0.4.1
msal-extensions~=0.1.2
msal<2.0.0,>=1.0.0
msal-extensions~=0.1.3
msrest>=0.5.0
msrestazure<2.0.0,>=0.4.32
requests>=2.18.4
Expand Down