Conversation
|
Can one of the admins verify this patch? |
bryevdv
reviewed
Oct 9, 2019
bryevdv
reviewed
Oct 9, 2019
bryevdv
reviewed
Oct 9, 2019
bryevdv
reviewed
Oct 9, 2019
Member
|
This will unfortunately be breaking to cosmos..... when was it intended to be released? If not till GA that's fine, as I can update Cosmos accordingly. |
bryevdv
reviewed
Oct 9, 2019
Contributor
There was a problem hiding this comment.
Sorry, I'm still confused by this. If the config object is omitted, how is it also what will be used? I think this is what happens based on looking at the code:
:keyword Configuration config: If omitted, a Configuration object created from additional keyword arguments will used by the PipelineClient.
but please let me know if that's off base.
Member
Author
There was a problem hiding this comment.
You are absolutely right!
annatisch
reviewed
Oct 9, 2019
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
bryevdv
reviewed
Oct 9, 2019
Contributor
There was a problem hiding this comment.
HttpTranpost -> HttpTranport
bryevdv
reviewed
Oct 9, 2019
Contributor
|
Typo noted, otherwise LGTM |
bryevdv
approved these changes
Oct 9, 2019
annatisch
approved these changes
Oct 9, 2019
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
Signing off for the cosmos changes :)
Contributor
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* increment key vault version (#7704) * Update ep livetest according to storage-blob-b4 (#7725) * Bug fix #6690 (#7738) * Fix auto-headers for aiohttp (for real this time :)) (#7749) * Fix auto-headers for aiohttp * ChangeLog * [AutoPR frontdoor/resource-manager] some fixes for frontdoor readme (#7714) * Generated from e5fa469589e9cddf953d91122ebf61fc705ea8bb renamed aggregation intervals * Generated from 729f3420dad818c11e458aa67483039fd9b48778 Updated timeseriesType * Generated from 9630e7a1f4c4c443797f8efa12d20bf1cf7a4dee scorecard -> scoreboard * Generated from 3a7dbc786a7789ef058736e2dfa8be0f7ab5f53d network experiment resource state * Packaging update of azure-mgmt-frontdoor * changelog * Fix requests asyncio if input data is async gen (#7743) * Fix requests asyncio if input data is async gen * ChangeLog * Feedback * Update HISTORY.md * update user agent string (#7750) * remove get_pending_certificate_signing_request (#7560)
xiangyan99
requested review from
YijunXieMS,
schaabs,
yunhaoling and
zikalino
as code owners
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* move config into kwargs * use pop to avoid dup values for kw arguement 'config' * update doc * fix cosmos client * pylint fix * remove config * fix typo * Get latest master (#7770) * increment key vault version (#7704) * Update ep livetest according to storage-blob-b4 (#7725) * Bug fix #6690 (#7738) * Fix auto-headers for aiohttp (for real this time :)) (#7749) * Fix auto-headers for aiohttp * ChangeLog * [AutoPR frontdoor/resource-manager] some fixes for frontdoor readme (#7714) * Generated from e5fa469589e9cddf953d91122ebf61fc705ea8bb renamed aggregation intervals * Generated from 729f3420dad818c11e458aa67483039fd9b48778 Updated timeseriesType * Generated from 9630e7a1f4c4c443797f8efa12d20bf1cf7a4dee scorecard -> scoreboard * Generated from 3a7dbc786a7789ef058736e2dfa8be0f7ab5f53d network experiment resource state * Packaging update of azure-mgmt-frontdoor * changelog * Fix requests asyncio if input data is async gen (#7743) * Fix requests asyncio if input data is async gen * ChangeLog * Feedback * Update HISTORY.md * update user agent string (#7750) * remove get_pending_certificate_signing_request (#7560) * pylint fix * update history.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.