Skip to content

Comments

update app config doc#7618

Merged
xiangyan99 merged 2 commits intomasterfrom
update_appconfig_doc
Oct 5, 2019
Merged

update app config doc#7618
xiangyan99 merged 2 commits intomasterfrom
update_appconfig_doc

Conversation

@xiangyan99
Copy link
Member

@xiangyan99 xiangyan99 commented Oct 4, 2019

No description provided.

@xiangyan99 xiangyan99 requested a review from bryevdv October 4, 2019 18:15
@adxsdk6
Copy link

adxsdk6 commented Oct 4, 2019

Can one of the admins verify this patch?

bryevdv
bryevdv reviewed Oct 4, 2019
View reviewed changes
doc/sphinx/ref/azure.appconfiguration.rst
azure.appconfiguration.azure\_appconfiguration\_requests module
---------------------------------------------------------------
azure.appconfiguration.azure\_appconfiguration\_credential module
-----------------------------------------------------------------
Copy link
Contributor

@bryevdv bryevdv Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with the \? Is that something specific to our sphinx setup? I have never had to do this in other projects where there were module names with underscores.

Copy link
Member Author

@xiangyan99 xiangyan99 Oct 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'\' is used in sphinx to escape '_'. The full name of the module is
azure.appconfiguration.azure_appconfiguration_requests

Copy link
Contributor

@bryevdv bryevdv Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, my confusion is that I've never known underscores to ever need escaping before :) e.g.

https://raw.githubusercontent.com/bokeh/bokeh/master/sphinx/source/docs/reference/tile_providers.rst

(with no escapes for underscores) generates

http://docs.bokeh.org/en/latest/docs/reference/tile_providers.html

Copy link
Member Author

@xiangyan99 xiangyan99 Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated by the sphinx tool. :)

@xiangyan99 xiangyan99 requested a review from mayurid as a code owner October 4, 2019 23:43
@xiangyan99 xiangyan99 merged commit f85c8ac into master Oct 5, 2019
iscai-msft pushed a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Oct 7, 2019
@xiangyan99 @iscai-msft
update app config doc (Azure#7618)
f740459 
* update app config doc

* move match_condition to internal
iscai-msft added a commit that referenced this pull request Oct 7, 2019
@iscai-msft
Key Vault: Design board changes (#7635)
c9683bd 
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (#7627)

* Core doc fix (#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (#7640)

* Eventhubs preview4 merge to master (#7605)

* [EventHubs] Eventhubs runtime metric (#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (#7575)

* Python EventHubs test code revamp (#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (#7643)

* Enable template for unified templates. (#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
@xiangyan99
update app config doc (Azure#7618)
a960eca 
* update app config doc

* move match_condition to internal
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
@iscai-msft
Key Vault: Design board changes (Azure#7635)
f937bf4 
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (Azure#7627)

* Core doc fix (Azure#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (Azure#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (Azure#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (Azure#7640)

* Eventhubs preview4 merge to master (Azure#7605)

* [EventHubs] Eventhubs runtime metric (Azure#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (Azure#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (Azure#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (Azure#7575)

* Python EventHubs test code revamp (Azure#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (Azure#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (Azure#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (Azure#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (Azure#7643)

* Enable template for unified templates. (Azure#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (Azure#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
kristapratico pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Oct 9, 2019
@iscai-msft @kristapratico
Key Vault: Design board changes (Azure#7635)
a4feb18 
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (Azure#7627)

* Core doc fix (Azure#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (Azure#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (Azure#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (Azure#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (Azure#7640)

* Eventhubs preview4 merge to master (Azure#7605)

* [EventHubs] Eventhubs runtime metric (Azure#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (Azure#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (Azure#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (Azure#7575)

* Python EventHubs test code revamp (Azure#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (Azure#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (Azure#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (Azure#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (Azure#7643)

* Enable template for unified templates. (Azure#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (Azure#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
@xiangyan99 xiangyan99 deleted the update_appconfig_doc branch October 22, 2019 22:14
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
@xiangyan99 @fengzhou-msft
update app config doc (#7618)
c04c317 
* update app config doc

* move match_condition to internal
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
@iscai-msft @fengzhou-msft
Key Vault: Design board changes (#7635)
1143cdb 
* switched vault_url to vault_endpoint across key vault

* moved enabled and tags to kwargs

* changed the name parameter for get_policy and update_policy to certificate_name

* updated changelog

* [Core] Updated release notes (#7627)

* Core doc fix (#7638)

* Fix azure-core examples

* Fix azure-core Readme

* Simplify doc

* Kill common.py file

* Remove tracing.ext

* update app config doc (#7618)

* update app config doc

* move match_condition to internal

* [AutoPR] netapp/resource-manager (#7092)

* Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (#7089)

Update netapp.json

* changelog for netapp

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API (#7460)

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* ANF-374 update for R5 RP version 2019-07-01 API

* extending pypy timeout. (#7640)

* Eventhubs preview4 merge to master (#7605)

* [EventHubs] Eventhubs runtime metric (#7431)

* runtime metric init commit

* evenhubts-runtime-metric implementation

* Update code, and test and docstring

* Add example code

* Update property name

* Update name to last enqueued event properties

* Eventhubs remove iot and linkredirect (#7450)

* Remove iothub/link-redirect related code

* Remove self._running from consumer and producer

* Remove IoT related params "operation" and "device"

* Remove exception from close()

* add iterator long running test

* small bug fix

* small bug fix

* Fix connection properties bug and format

* Changed product to azure-eventhub in user agent

* Fix a type hint

* Improve stress script

* Print to console configurable

* small changes

* Disable tracking last enqueued event properties for uamqp 1.2.2

* use different consumer group

* fix an issue about consumer group

* fix an issue about consumer group

* Fix a get_properties bug

* [EventHubs] Performance improvement (#7533)

* performance improvement

* batch offset

* Review feedback

* Remove lazy parse in EventData

* Add annotation assertions

* Small fix for missing annotation initialization (#7575)

* Python EventHubs test code revamp (#7594)

* fix pylint error

* fix mypy error

* fix for 2.7

* fix for 2.7

* Sleep 300 seconds to test reconnect

* Remove Pypy from eventhub live test

* Remove Pypy from eventhub live test

* Add "Matrix:"

* Fix bug passing timeout in seconds to uamqp

* update checkpointstore HISTORY

* [EventHubs] Update documentations (#7603)

* Update docs

* Update iothub related description

* Docs update

* Small fix

* Small fix

* revert setup.py

* Resolve Global Install Errors (#7642)

* swapping all dev_requirements to leverage the non-develop mode. opencensus-tracing will fail if azure-core is installed in dev mode. all the rest of the tests are ok with using non-dev, so this seems to be a good compromise

* Setup core for unified pipelines. (#7577)

* Setup core for unified pipelines.

* Added open census to the core pipeline (can be released independently).

* Publish the packages artifact. (#7643)

* Enable template for unified templates. (#7644)

* Setup template for UP.

* Fixed service directory.

* ensure error_map is used consistently and correctly (#7637)

* switched vault_url to vault_endpoint across key vault

* ran black on keyvault

* reverted <<<HEAD additions to code

* got rid of black changes that broke python 3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

@mayurid mayurid Awaiting requested review from mayurid

+1 more reviewer

@bryevdv bryevdv bryevdv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiangyan99 @adxsdk6 @lmazuel @bryevdv