SansIOHttpPolicy can return awaitable objects#7497
Merged
Conversation
Contributor
|
(message created by the CI based on PR content) Installation instructionPackage azure-coreYou can install the package You can build a wheel to distribute for test using the following command: If you have a local clone of this repository, you can also do:
Or build a wheel file to distribute for testing:
Direct downloadYour files can be directly downloaded here: |
bryevdv
reviewed
Sep 30, 2019
bryevdv
approved these changes
Sep 30, 2019
Member
Author
|
Note: requires #7497 to support AAD async batch |
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* Make BearerTokenCredentialPolicy a SansIOHTTPPolicy * Allow SansIOHTTPPolicy to return awaitables * SansIOHttpPolicy doc * typo * Awaitable not backported in typing for 2.7 + black * Fix typing * Feedbacks from Anna * Check sync runner doesn't get a coroutine * pylint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coroutine being awaitable objects, this means we can define on_request/on_response/on_exception as coroutine (corollary).