Async blob code samples #6728
Async blob code samples #6728
Conversation
|
Can one of the admins verify this patch? |
| :param int timeout: | ||
| The timeout parameter is expressed in seconds. | ||
| :returns: A LeaseClient object. | ||
| :rtype: ~azure.storage.blob.lease.LeaseClient |
There was a problem hiding this comment.
I'd use this PR to update rtypes here to something like this
~azure.storage.blob.aio.lease_async.LeaseClient
There was a problem hiding this comment.
Good point, I'll do this.
| :start-after: [START copy_blob_from_url] | ||
| :end-before: [END copy_blob_from_url] | ||
| :language: python | ||
| :dedent: 12 |
There was a problem hiding this comment.
should dedent be 8? I see 8 dedent in some places.
There was a problem hiding this comment.
12 is correct. It depends on how indented the code sample is and how many dedents are needed to avoid excess whitespace.
| :start-after: [START abort_copy_blob_from_url] | ||
| :end-before: [END abort_copy_blob_from_url] | ||
| :language: python | ||
| :dedent: 12 |
There was a problem hiding this comment.
same here...should dedent be 8?
There was a problem hiding this comment.
12 looks good in the local docs here as well.
|
client - ci and storage - ci checks are all green so I'm going to merge. Apparently there is a github bug that is causing the checks to look like they are still in progress. |
verified green CI |
3 participants
Verified correct formatting with sphinx locally.