Skip to content

Conversation

@yunhaoling
Copy link
Contributor

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Aug 7, 2019

Can one of the admins verify this patch?

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adam! First Sphinx commit! I don't see any issues with the PR. Just double checking, did you run make html and confirm that everything looked right in the local site?

@yunhaoling
Copy link
Contributor Author

@scbedd yes!
I fixed all the warnings that sphinx output and checked the html files.
But I'm not sure whether I could simply merge this PR into master. I'm checking with @annatisch .

@yunhaoling yunhaoling merged commit 787d65f into Azure:master Aug 8, 2019
@yunhaoling yunhaoling deleted the eventhub-doc branch September 17, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants