Skip to content

Conversation

@xingwu1
Copy link
Member

@xingwu1 xingwu1 commented Aug 7, 2019

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Aug 7, 2019

Can one of the admins verify this patch?

@xingwu1
Copy link
Member Author

xingwu1 commented Aug 9, 2019

@lmazuel @zikalino Could you help me review it and merge it?

- Shared Image Gallery images can now be specified on the `id` property of `ImageReference` by referencing the image via its ARM ID.
- **[Breaking]** When not specified, the default value for `wait_for_success` on `StartTask` is now `True` (was `False`).
- **[Breaking]** When not specified, the default value for `scope` on `AutoUserSpecification` is now always `Pool` (was `Task` on Windows nodes, `Pool` on Linux nodes).
- **Breaking** Model signatures are now using only keywords-arguments syntax. Each positional argument must be rewritten as a keyword argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking [](start = 4, length = 8)

nit forgot brackets

Copy link
Contributor

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@xingwu1 xingwu1 merged commit 889c15d into Azure:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants