Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Aug 7, 2019

This should fix any CI issues introduced by adjusted test environments.

Test results are now outputting under a directory labelled with the package they ran for. PublishTestResults should be collecting from all these directories combined now.

Also running black formatting on the devops_scripts folder.

logging module does a lot to make the output readable.

Currently trying to understand why .coverage isn't actually uploading any results in some situations. We're definitely properly running --cov vs --cov-append in the correct locations.

@adxsdk6
Copy link

adxsdk6 commented Aug 7, 2019

Can one of the admins verify this patch?

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The changes to testResultsFiles looks like it picks up an extra 5 tests for each of the 8 matrix entries.

@scbedd
Copy link
Member Author

scbedd commented Aug 8, 2019

LGTM.

The changes to testResultsFiles looks like it picks up an extra 5 tests for each of the 8 matrix entries.

Thanks for looking at this! I will just leave the 5 additional tests alone. I will note that this PR broke coverage because of the fact that for some reason pytest-cov will only properly append coverage results if there is an already existing .coverage file! I have pushed an update that addresses this.

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6fafa36). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6710   +/-   ##
=========================================
  Coverage          ?   39.94%           
=========================================
  Files             ?      416           
  Lines             ?    16521           
  Branches          ?        0           
=========================================
  Hits              ?     6600           
  Misses            ?     9921           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fafa36...a7f1fd7. Read the comment docs.

@scbedd
Copy link
Member Author

scbedd commented Aug 8, 2019

/azp run python - client - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

scbedd and others added 6 commits August 9, 2019 13:46
…, which means that --cov won't generate a .coverage file. however, --cov-append only works with an existing .coverage, so you gotta keep using --cov until you actually get a generated .coverage file. Then you can swap to --cov-append
@scbedd
Copy link
Member Author

scbedd commented Aug 11, 2019

/azp run python - client - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd merged commit 4f3eb73 into Azure:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants