-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Set up environment once, run tests one at a time #6710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
…t this fixes the print() ordering issues we were having.
danieljurek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The changes to testResultsFiles looks like it picks up an extra 5 tests for each of the 8 matrix entries.
Thanks for looking at this! I will just leave the 5 additional tests alone. I will note that this PR broke coverage because of the fact that for some reason |
Codecov Report
@@ Coverage Diff @@
## master #6710 +/- ##
=========================================
Coverage ? 39.94%
=========================================
Files ? 416
Lines ? 16521
Branches ? 0
=========================================
Hits ? 6600
Misses ? 9921
Partials ? 0Continue to review full report at Codecov.
|
|
/azp run python - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…, which means that --cov won't generate a .coverage file. however, --cov-append only works with an existing .coverage, so you gotta keep using --cov until you actually get a generated .coverage file. Then you can swap to --cov-append
|
/azp run python - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…itch to a coverage collection at the end
This should fix any CI issues introduced by adjusted test environments.
Test results are now outputting under a directory labelled with the package they ran for. PublishTestResults should be collecting from all these directories combined now.
Also running
blackformatting on the devops_scripts folder.loggingmodule does a lot to make the output readable.Currently trying to understand why .coverage isn't actually uploading any results in some situations. We're definitely properly running
--covvs--cov-appendin the correct locations.