Skip to content

Conversation

@AutorestCI
Copy link
Contributor

Created to accumulate context: containerregistry/resource-manager

Revert "set a default api version (#6588)"

This reverts commit 2200abd.
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jul 30, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerregistry

You can install the package azure-mgmt-containerregistry of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerregistry/resource-manager#egg=azure-mgmt-containerregistry&subdirectory=azure-mgmt-containerregistry"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerregistry/resource-manager#egg=azure-mgmt-containerregistry&subdirectory=azure-mgmt-containerregistry"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_containerregistry/resource-manager
  • pip install -e ./azure-mgmt-containerregistry

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_containerregistry/resource-manager
  • pip wheel --no-deps ./azure-mgmt-containerregistry

Direct download

Your files can be directly downloaded here:

@ankurkhemani
Copy link

ankurkhemani commented Jul 30, 2019

@zikalino 3.0.0rc4 is already released. Not sure why PR generates that whl.
Can you please help me merge this multi-api python sdk and release it to PyPI?
// cc @lmazuel

@zikalino
Copy link

@ankurkhemani when I verify and change version it will generate proper version and then it will be released with right version number. I will handle this today.

@ankurkhemani
Copy link

@zikalino Did you get a chance to work on this?

@zikalino
Copy link

zikalino commented Aug 2, 2019

@ankurkhemani I am ready to release package, just would like to learn what was the idea behind changing api version earlier and now reverting it back.

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #6543 into master will increase coverage by 8%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6543       +/-   ##
===========================================
+ Coverage   48.94%   56.95%       +8%     
===========================================
  Files        7304       71     -7233     
  Lines      294242     8140   -286102     
===========================================
- Hits       144019     4636   -139383     
+ Misses     150223     3504   -146719
Impacted Files Coverage Δ
...rregistry/_container_registry_management_client.py 42.1% <100%> (+2.33%) ⬆️
...erregistry/azure/mgmt/containerregistry/version.py 100% <100%> (ø) ⬆️
...v2017_10_01/operations/_replications_operations.py 14.76% <0%> (-77.19%) ⬇️
...try/v2017_10_01/operations/_webhooks_operations.py 13.27% <0%> (-72.04%) ⬇️
...y/v2017_10_01/operations/_registries_operations.py 12.12% <0%> (-56.67%) ⬇️
sdk/core/azure-common/azure/common/__init__.py 54.54% <0%> (-45.46%) ⬇️
...mt/containerregistry/v2017_10_01/models/_models.py 50.78% <0%> (-19.75%) ⬇️
...ontainerregistry/v2017_10_01/models/_models_py3.py 50.78% <0%> (-19.75%) ⬇️
...tainerregistry/v2017_10_01/models/_paged_models.py 76.19% <0%> (-19.05%) ⬇️
sdk/core/azure-common/azure/profiles/__init__.py 69.76% <0%> (-16.28%) ⬇️
... and 7269 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379c1a1...b7e7ab6. Read the comment docs.

@zikalino
Copy link

zikalino commented Aug 2, 2019

@ankurkhemani
seems like there are test failures, and i need to re-record them.
just wonder how it was passing before....

@ankurkhemani
Copy link

@zikalino Not sure about the tests here. @lmazuel ?

@zikalino zikalino merged commit faddcba into master Aug 6, 2019
@zikalino zikalino deleted the restapi_auto_containerregistry/resource-manager branch August 6, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants