[SnapshotSAS]Add Snapshot SAS#6445
Closed
xiafu-msft wants to merge 6 commits intoAzure:storage-preview3from
Closed
[SnapshotSAS]Add Snapshot SAS#6445xiafu-msft wants to merge 6 commits intoAzure:storage-preview3from
xiafu-msft wants to merge 6 commits intoAzure:storage-preview3from
Conversation
* Refactored blob shared utils * Refactored file shared utils * Refactored queue shared utils * Refactored downloads * Refactored file downloads * Started async downloads * Async Files API * Flatten copy polling * Renamed uploads * Fixes samples based on vendor feedback (Azure#6357) * fixed import statements for sync samples * fixed secrets readme samples * fixed keys readme samples * deduped secret names across samples * Upload refactor * Release approval docs (Azure#6361) * updating dev documentation with approval details * Updated async pipeline * Avoid surprising aiohttp with unexpected kwargs (Azure#6355) * Add challenge authentication to azure-keyvault-keys (Azure#6244) * Add decorator (Azure#6299) * add opencensus impl * dont need to check for noop tracer * get rid of span and trace id * fix span instance * added documentation * added documentation and refactor names of a few variables * write test for opencensus wrapper * put opencensus in the dev requirements * initial common * only import the wrapper when necessary * add check for the exporter * rework logic and fix some settings * added initial decorator * some mroe documentation * added decorators * small change * some minor fixes * test patch happening * fix space * share a function * clearer logic for setting span context * better logic * better logic * fix environ variable * test the way opencensus does it * middle of tests * only load if opencensus has already been imported * fix spelling mistake * temp * finish writing tests for common * charles fixes * fix tests * fix test settings * to header should not take a dict * from header should be class method * initial tests * dont create trace and get rid of end_tracer * dont need to save the trace * more little fixes * some intermediatary changes * fix type annotations * rst fix types * add :class:annotations * fix line wrapping * added tests for decorator * rename opencensus wrapper * intermediate changes * use spans the right way * some formatting * some grammar * restructure settings and make tests pass * rename get_parent * fix typings * use protocol and from_headers becomes links * ramifications of opencensus wrapper being a protocol * add tests for link * added async tests * delete the unit test thing * added add_attribute * added add_attribute * added tests for add attributes * remove unused import * added docstrings * minor docstring formatting * fix pylint errors * don't rely on opencensus children to check * use exporter to not rely on parent.children * test should only propagate * made test tracing helper * decrease flakiness of test * simplify get parent * calling a decorator decorator is redundant * fix settings * more elegant code * add await for async * should only have to wait a 1/1000 of a second * fix tests spans too short * accidentally deleted setup.cfg * Added async file tests * Consolidate Key Vault shared code (Azure#6384) * Download tests * Service property tests * No recordings * Add credential wrapping MSAL ConfidentialClientApplication (Azure#6358) * Add policy (Azure#6379) * add opencensus impl * dont need to check for noop tracer * get rid of span and trace id * fix span instance * added documentation * added documentation and refactor names of a few variables * write test for opencensus wrapper * put opencensus in the dev requirements * initial common * only import the wrapper when necessary * add check for the exporter * rework logic and fix some settings * added initial decorator * some mroe documentation * added decorators * small change * some minor fixes * test patch happening * fix space * share a function * clearer logic for setting span context * better logic * better logic * fix environ variable * test the way opencensus does it * middle of tests * only load if opencensus has already been imported * fix spelling mistake * temp * finish writing tests for common * charles fixes * fix tests * fix test settings * to header should not take a dict * from header should be class method * initial tests * dont create trace and get rid of end_tracer * dont need to save the trace * more little fixes * some intermediatary changes * fix type annotations * rst fix types * add :class:annotations * fix line wrapping * added tests for decorator * rename opencensus wrapper * intermediate changes * use spans the right way * some formatting * some grammar * restructure settings and make tests pass * rename get_parent * fix typings * use protocol and from_headers becomes links * ramifications of opencensus wrapper being a protocol * add tests for link * added async tests * delete the unit test thing * added add_attribute * added add_attribute * added tests for add attributes * add initial policy * remove unused import * added docstrings * minor docstring formatting * fix pylint errors * don't rely on opencensus children to check * use exporter to not rely on parent.children * added documentation and span attributes * added test tracing policy * test should only propagate * made test tracing helper * decrease flakiness of test * simplify get parent * calling a decorator decorator is redundant * middle of writing tests * fix settings * add tests * test propogation also happens * more elegant code * await async stuff * add await for async * should only have to wait a 1/1000 of a second * fix tests spans too short * accidentally deleted setup.cfg * add component * add set_http_attributes * fix span network name * fix http request types * fix more types * bryan fixes * more efficient tests * non flakey tests * make tracing only use my context * test user agent on exception * pylint formatting * delete unused import * fix spelling * pylint * adding dockerfile (Azure#6393) * Update cheatsheet.md * Async share tests * Async directory tests * Fixed some tests * aiohttp socket timeout * Patch azure core * CI fixes * Fix async tests for py35 * Python 3.5 support * Clean pylint
* Async Queues + tests port * More tests plus changes * pytest conf * Port shared folder * remove warnings from tests * Latest shared code * change destination * some more changes * ..and some more * fix tests * pylint + mypy * some more lint * A couple of test fixes * Fixed fake settings mode * Refactored queue utils * change conf ignore * minor change * Fix for urlencoding SAS tokens
|
Can one of the admins verify this patch? |
Contributor
Author
|
This is for preview3 so don't merge into master 😀 |
xiafu-msft
commented
Jul 23, 2019
| BlobPermissions.WRITE = BlobPermissions(write=True) | ||
|
|
||
|
|
||
| class UserDelegationKey(object): |
Contributor
Author
There was a problem hiding this comment.
It seems this will be added by autorest, I will delete this in the second revision
annatisch
force-pushed
the
storage-preview3
branch
from
c755392 to
f869b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.