Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
657c34e
add opencensus impl
SuyogSoti Jul 9, 2019
8573e23
dont need to check for noop tracer
SuyogSoti Jul 9, 2019
989c4dc
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 9, 2019
3f64325
get rid of span and trace id
SuyogSoti Jul 9, 2019
0b04d80
fix span instance
SuyogSoti Jul 9, 2019
9f4e507
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 9, 2019
7b728d8
added documentation
SuyogSoti Jul 9, 2019
bfd355c
added documentation and refactor names of a few variables
SuyogSoti Jul 9, 2019
cd06c97
write test for opencensus wrapper
SuyogSoti Jul 10, 2019
a9f7a6f
put opencensus in the dev requirements
SuyogSoti Jul 10, 2019
b8f63df
initial common
SuyogSoti Jul 10, 2019
408c5ad
only import the wrapper when necessary
SuyogSoti Jul 10, 2019
9baf366
add check for the exporter
SuyogSoti Jul 10, 2019
f4c52fd
rework logic and fix some settings
SuyogSoti Jul 10, 2019
d439df9
added initial decorator
SuyogSoti Jul 10, 2019
f256d62
some mroe documentation
SuyogSoti Jul 10, 2019
9067279
added decorators
SuyogSoti Jul 10, 2019
eee5e09
small change
SuyogSoti Jul 10, 2019
6050bd7
some minor fixes
SuyogSoti Jul 10, 2019
c9faa4b
test patch happening
SuyogSoti Jul 10, 2019
6d35557
fix space
SuyogSoti Jul 10, 2019
0f6c1f7
share a function
SuyogSoti Jul 10, 2019
2bfffe5
clearer logic for setting span context
SuyogSoti Jul 10, 2019
c1f6d69
better logic
SuyogSoti Jul 10, 2019
18890ea
better logic
SuyogSoti Jul 10, 2019
6a4a545
fix environ variable
SuyogSoti Jul 11, 2019
e7b5707
test the way opencensus does it
SuyogSoti Jul 11, 2019
aaf2152
middle of tests
SuyogSoti Jul 11, 2019
7ccf041
only load if opencensus has already been imported
SuyogSoti Jul 11, 2019
6a01918
fix spelling mistake
SuyogSoti Jul 11, 2019
36572c5
temp
SuyogSoti Jul 11, 2019
d9a2d95
Merge branch 'opencensus_impl' into temp
SuyogSoti Jul 11, 2019
280173f
finish writing tests for common
SuyogSoti Jul 11, 2019
b3f44fb
charles fixes
SuyogSoti Jul 11, 2019
9cb1bd9
Merge branch 'opencensus_impl' into temp
SuyogSoti Jul 11, 2019
77e0ccf
fix tests
SuyogSoti Jul 11, 2019
1e9c7dc
fix test settings
SuyogSoti Jul 11, 2019
d72248e
to header should not take a dict
SuyogSoti Jul 11, 2019
135d1c0
from header should be class method
SuyogSoti Jul 11, 2019
56e8269
Merge branch 'opencensus_impl' into temp
SuyogSoti Jul 11, 2019
73203c2
initial tests
SuyogSoti Jul 11, 2019
e304d40
dont create trace and get rid of end_tracer
SuyogSoti Jul 11, 2019
ff5627d
dont need to save the trace
SuyogSoti Jul 11, 2019
1e4b03a
more little fixes
SuyogSoti Jul 11, 2019
d55bca1
Merge branch 'opencensus_impl' into temp
SuyogSoti Jul 11, 2019
72e0dd4
some intermediatary changes
SuyogSoti Jul 11, 2019
aa5b671
fix type annotations
SuyogSoti Jul 11, 2019
0ce1a22
rst fix types
SuyogSoti Jul 11, 2019
b9c7d72
add :class:annotations
SuyogSoti Jul 11, 2019
57b2a57
fix line wrapping
SuyogSoti Jul 11, 2019
9b6260e
Merge branch 'opencensus_impl' into temp
SuyogSoti Jul 11, 2019
8b1ed8f
added tests for decorator
SuyogSoti Jul 12, 2019
c041818
rename opencensus wrapper
SuyogSoti Jul 12, 2019
8da57ec
Merge branch 'opencensus_impl' into overall
SuyogSoti Jul 12, 2019
56d2e7d
intermediate changes
SuyogSoti Jul 12, 2019
de6f552
use spans the right way
SuyogSoti Jul 12, 2019
691eb3d
some formatting
SuyogSoti Jul 12, 2019
6a1f733
Merge branch 'opencensus_impl' into overall
SuyogSoti Jul 12, 2019
20d5afe
some grammar
SuyogSoti Jul 12, 2019
c55c901
Merge branch 'opencensus_impl' into overall
SuyogSoti Jul 12, 2019
3e80b1e
restructure settings and make tests pass
SuyogSoti Jul 12, 2019
3f9f4ae
rename get_parent
SuyogSoti Jul 12, 2019
412bf7a
fix typings
SuyogSoti Jul 12, 2019
3c6ab1c
use protocol and from_headers becomes links
SuyogSoti Jul 12, 2019
de8b5f4
Merge branch 'opencensus_impl' into overall
SuyogSoti Jul 12, 2019
de41353
ramifications of opencensus wrapper being a protocol
SuyogSoti Jul 12, 2019
db2f865
add tests for link
SuyogSoti Jul 12, 2019
7c637e6
Merge branch 'opencensus_impl' into overall
SuyogSoti Jul 12, 2019
27c9876
added async tests
SuyogSoti Jul 12, 2019
ac9ff09
delete the unit test thing
SuyogSoti Jul 12, 2019
f0ba4ee
fix merge conflict
SuyogSoti Jul 12, 2019
ff07c55
added add_attribute
SuyogSoti Jul 13, 2019
30fd165
added add_attribute
SuyogSoti Jul 13, 2019
644fe2a
added tests for add attributes
SuyogSoti Jul 13, 2019
fc6a284
Merge branch 'opencensus_impl' into add_decorator
SuyogSoti Jul 13, 2019
8f137c1
remove unused import
SuyogSoti Jul 13, 2019
8e8aa21
Merge branch 'master' into add_decorator
SuyogSoti Jul 13, 2019
a373e40
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 15, 2019
0c37b38
added docstrings
SuyogSoti Jul 15, 2019
b925782
minor docstring formatting
SuyogSoti Jul 15, 2019
4dd6ba9
fix pylint errors
SuyogSoti Jul 15, 2019
fae494a
don't rely on opencensus children to check
SuyogSoti Jul 15, 2019
e484bcf
use exporter to not rely on parent.children
SuyogSoti Jul 15, 2019
76c75bc
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 15, 2019
9d0159c
test should only propagate
SuyogSoti Jul 16, 2019
aa14218
made test tracing helper
SuyogSoti Jul 16, 2019
bc35a5f
decrease flakiness of test
SuyogSoti Jul 16, 2019
85e5e48
simplify get parent
SuyogSoti Jul 16, 2019
91d1d25
calling a decorator decorator is redundant
SuyogSoti Jul 16, 2019
603d4f6
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 16, 2019
056bc2e
fix settings
SuyogSoti Jul 16, 2019
720c44e
more elegant code
SuyogSoti Jul 16, 2019
f503b6e
add await for async
SuyogSoti Jul 16, 2019
6743bd1
should only have to wait a 1/1000 of a second
SuyogSoti Jul 16, 2019
c070b77
fix tests spans too short
SuyogSoti Jul 17, 2019
df7f09e
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
SuyogSoti Jul 17, 2019
d106a16
accidentally deleted setup.cfg
SuyogSoti Jul 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions sdk/core/azure-core/azure/core/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
import os
from typing import Any, Union

from azure.core.tracing import AbstractSpan


__all__ = ("settings",)

Expand Down Expand Up @@ -110,6 +112,47 @@ def convert_logging(value):
return level


def _get_opencensus_wrapper():
# type: () -> OpencensusWrapper
"""Returns the OpencensusWrapper if opencensus is installed else returns None"""
try:
from azure.core.tracing.ext.opencensus_wrapper import OpencensusWrapper

return OpencensusWrapper
except ImportError:
return None


def convert_tracing_impl(value):
# type: (Union[str, AbstractSpan]) -> AbstractSpan
"""Convert a string to AbstractSpan

If a AbstractSpan is passed in, it is returned as-is. Otherwise the function
understands the following strings, ignoring case:

* "opencensus"

:param value: the value to convert
:type value: string
:returns: AbstractSpan
:raises ValueError: If conversion to AbstractSpan fails

"""
if issubclass(value.__class__, AbstractSpan):
return value

_impl_dict = {"opencensus": _get_opencensus_wrapper()}
wrapper_class = _impl_dict.get(value, None)
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
if wrapper_class is None:
raise ValueError(
"Cannot convert {} to AbstractSpan, valid values are: {}".format(
value, ", ".join(_impl_dict)
)
)

return wrapper_class


class PrioritizedSetting(object):
"""Return a value for a global setting according to configuration precedence.

Expand Down Expand Up @@ -361,5 +404,19 @@ def _config(self, props): # pylint: disable=no-self-use
default=False,
)

tracing_implementation = PrioritizedSetting(
"tracing_implementation",
env_var="AZURE_SDK_TRACING_IMPLEMENTATION",
convert=convert_tracing_impl,
default=None,
)

tracing_should_only_propagate = PrioritizedSetting(
"tracing_should_only_propagate",
env_var="AZURE_TRACING_ONLY_PROPAGATE",
convert=convert_bool,
default=False,
)


settings = Settings()
12 changes: 11 additions & 1 deletion sdk/core/azure-core/azure/core/tracing/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
# ------------------------------------
from azure.core.tracing.abstract_span import AbstractSpan
from azure.core.tracing.context import tracing_context
from azure.core.tracing.decorator import distributed_tracing_decorator

__all__ = ["tracing_context", "AbstractSpan"]
try:
from azure.core.tracing.decorator_async import distributed_tracing_decorator_async
except ImportError:
distributed_tracing_decorator_async = lambda x: x

__all__ = [
"tracing_context",
"AbstractSpan",
"distributed_tracing_decorator",
"distributed_tracing_decorator_async",
]
91 changes: 91 additions & 0 deletions sdk/core/azure-core/azure/core/tracing/common.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
# --------------------------------------------------------------------------
Comment thread
SuyogSoti marked this conversation as resolved.
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#
# The MIT License (MIT)
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the ""Software""), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
#
# --------------------------------------------------------------------------
from os import environ
import re

from azure.core.tracing.context import tracing_context
from azure.core.tracing.abstract_span import AbstractSpan
from azure.core.settings import settings


def _get_opencensus_wrapper():
# type: () -> OpencensusWrapper
"""Returns the OpencensusWrapper if opencensus is installed else returns None"""
try:
from azure.core.tracing.ext.opencensus_wrapper import OpencensusWrapper

return OpencensusWrapper
except ImportError:
return None
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated


def set_span_contexts(wrapped_span, span_instance=None, impl_wrapper=None):
# type: (AbstractSpan, AbstractSpan) -> None
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
tracing_context.current_span.set(wrapped_span)
impl_wrapper = impl_wrapper or wrapped_span
tracing_context.tracing_impl.set(impl_wrapper.__class__)
if wrapped_span is not None or (
span_instance is not None and impl_wrapper is not None
):
span_instance = span_instance or wrapped_span.span_instance
impl_wrapper.set_current_span(span_instance)
Comment thread
SuyogSoti marked this conversation as resolved.


def get_parent(kwargs, *args):
# type: (Any) -> Tuple(Any, Any, Any)
"""Returns the parent span that of the span that represents the function and the spans before that parent span"""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this function. The name suggests it returns one span. The docstring is tough to parse and kind of supports that (a serial comma would help clarify). However, the type hint promises an arbitrary triple, and the function secretly accepts a parent_span argument. If I already have parent_span, do I call get_parent to get its parent? What's the triple for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to get_parent_and_original_contexts

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it to get_parent_span

parent_span = kwargs.pop("parent_span", None) # type: AbstractSpan
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
orig_wrapped_span = tracing_context.current_span.get()

# wrapper class get from tracing_context, settings or assume OpencensusWrapper if opencesus is installed
wrapper_class = (
tracing_context.tracing_impl.get()
or settings.tracing_implementation()
or _get_opencensus_wrapper()
)
if wrapper_class is None:
return None, orig_wrapped_span, None

# parent span is given, get from my context, get from the implementation context or make our own
parent_span = (
orig_wrapped_span if parent_span is None else wrapper_class(parent_span)
)
if parent_span is None:
current_span = wrapper_class.get_current_span()
parent_span = (
wrapper_class(span=current_span)
if current_span
else wrapper_class(name="azure-sdk-for-python-first_parent_span")
)

return parent_span, orig_wrapped_span, wrapper_class.get_current_span()


def should_use_trace(parent_span):
# type: (AbstractSpan, List[str], str)
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
"""Given Parent Span Returns whether the function should be traced"""
only_propagate = settings.tracing_should_only_propagate()
return parent_span and not only_propagate
3 changes: 2 additions & 1 deletion sdk/core/azure-core/azure/core/tracing/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Licensed under the MIT License.
# ------------------------------------
import threading
from azure.core.settings import settings

try:
from typing import TYPE_CHECKING
Expand Down Expand Up @@ -129,7 +130,7 @@ def with_current_context(self, func):
:return: The target the pass in instead of the function
"""
wrapped_span = tracing_context.current_span.get()
wrapper_class = self.tracing_impl.get()
wrapper_class = self.tracing_impl.get() or settings.tracing_implementation()
if wrapper_class is not None:
current_impl_span = wrapper_class.get_current_span()
current_impl_tracer = wrapper_class.get_current_tracer()
Expand Down
58 changes: 58 additions & 0 deletions sdk/core/azure-core/azure/core/tracing/decorator.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# --------------------------------------------------------------------------
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#
# The MIT License (MIT)
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the ""Software""), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
#
# --------------------------------------------------------------------------
import functools
import azure.core.tracing.common as common

def distributed_tracing_decorator(func):
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
# type: (Callable[[Any], Any]) -> Callable[[Any], Any]
@functools.wraps(func)
def wrapper_use_tracer(self, *args, **kwargs):
# type: (Any) -> Any
parent_span, original_span_from_sdk_context, original_span_instance = common.get_parent(
kwargs
)
ans = None
if common.should_use_trace(parent_span, func.__name__):
Comment thread
SuyogSoti marked this conversation as resolved.
Outdated
common.set_span_contexts(parent_span)
name = self.__class__.__name__ + "." + func.__name__
child = parent_span.span(name=name)
child.start()
common.set_span_contexts(child)
ans = func(self, *args, **kwargs)
child.finish()
common.set_span_contexts(parent_span)
if getattr(parent_span, "was_created_by_azure_sdk", False):
parent_span.finish()
common.set_span_contexts(
original_span_from_sdk_context,
span_instance=original_span_instance,
impl_wrapper=parent_span,
)
else:
ans = func(self, *args, **kwargs)
return ans

return wrapper_use_tracer
58 changes: 58 additions & 0 deletions sdk/core/azure-core/azure/core/tracing/decorator_async.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# --------------------------------------------------------------------------
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#
# The MIT License (MIT)
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the ""Software""), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
#
# --------------------------------------------------------------------------
import functools
import azure.core.tracing.common as common

def distributed_tracing_decorator_async(func):
# type: (Callable[[Any], Any]) -> Callable[[Any], Any]
@functools.wraps(func)
async def wrapper_use_tracer(self, *args, **kwargs):
# type: (Any) -> Any
parent_span, original_span_from_sdk_context, original_span_instance = common.get_parent(
kwargs
)
ans = None
if common.should_use_trace(parent_span, func.__name__):
common.set_span_contexts(parent_span)
name = self.__class__.__name__ + "." + func.__name__
child = parent_span.span(name=name)
child.start()
common.set_span_contexts(child)
ans = await func(self, *args, **kwargs)
child.finish()
common.set_span_contexts(parent_span)
if getattr(parent_span, "was_created_by_azure_sdk", False):
parent_span.finish()
common.set_span_contexts(
original_span_from_sdk_context,
span_instance=original_span_instance,
impl_wrapper=parent_span,
)
else:
ans = await func(self, *args, **kwargs)
return ans

return wrapper_use_tracer