[azure-core] Fixes 'no retries' config in retry policy#5803
Merged
kristapratico merged 5 commits intoAzure:masterfrom Jun 12, 2019
Merged
[azure-core] Fixes 'no retries' config in retry policy#5803kristapratico merged 5 commits intoAzure:masterfrom
kristapratico merged 5 commits intoAzure:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Can we add a basic test to exercise basic instance creation with |
xiangyan99
requested changes
Jun 11, 2019
Member
xiangyan99
left a comment
xiangyan99
left a comment
There was a problem hiding this comment.
It looks to me the no_retries method requires an input but in our samples, there is no input. Please double check.
rajivnandivada
pushed a commit
to rajivnandivada/azure-sdk-for-python
that referenced
this pull request
Jul 3, 2019
* fixes no retries config * adds a no retries test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.