Skip to content

Fix regression of PipelineRequest in retry#5791

Merged
xiangyan99 merged 2 commits intomasterfrom
FixPipelineRequestRegression
Jun 11, 2019
Merged

Fix regression of PipelineRequest in retry#5791
xiangyan99 merged 2 commits intomasterfrom
FixPipelineRequestRegression

Conversation

@xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from bryevdv as a code owner June 10, 2019 23:30
@adxsdk6
Copy link

adxsdk6 commented Jun 10, 2019

Can one of the admins verify this patch?

@bryevdv
Copy link
Contributor

bryevdv commented Jun 10, 2019

LGTM to me. For my own edification, what other sorts of responses can come through (or is this just a guard against None?)

@kristapratico
Copy link
Contributor

Also LGTM, good catch.

@bryevdv This is due to the increment method accepting either the pipeline response or pipeline request under the same response param.

In the send method...
retry_active = self.increment(retry_settings, response=response)
and
retry_active = self.increment(retry_settings, response=request, error=err)

@xiangyan99 xiangyan99 merged commit e8882fb into master Jun 11, 2019
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
@xiangyan99 xiangyan99 deleted the FixPipelineRequestRegression branch July 29, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants