Conversation
lmazuel
requested review from
annatisch,
chlowell,
hvermis,
kalyanaj,
matthchr,
ro-joowan,
samkreter,
schaabs and
zqingqing1
as code owners
scbedd
reviewed
Jun 7, 2019
scbedd
requested changes
Jun 7, 2019
Member
There was a problem hiding this comment.
I do feel that sdk/template/azure-template's readme should remain markdown instead of updating to rst. Fine with discussing tho!
The change you made to dev_setup.py makes sense to me. Pretty much exactly what I was expecting.
EDIT: after your response. I stand corrected.
rajivnandivada
pushed a commit
to rajivnandivada/azure-sdk-for-python
that referenced
this pull request
Jul 3, 2019
* Move to SDK tools * Change them all * Update dev_setup * Template should ask no update by default * Refix dev_setup * Do not check Readme inside tools folder * Re-re-fix and tested dev_setup * Blackened
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To host azure-sdk-tools and azure-devtools