Incorporate architecture board feedback#5728
Merged
chlowell merged 13 commits intoAzure:masterfrom Jun 7, 2019
Merged
Conversation
chlowell
added
Client
|
Can one of the admins verify this patch? |
schaabs
reviewed
Jun 7, 2019
schaabs
reviewed
Jun 7, 2019
Contributor
|
Modulo things I don't have context to evaluate (e.g IMDS and MSI creds needing to be internal) LGTM |
schaabs
reviewed
Jun 7, 2019
schaabs
reviewed
Jun 7, 2019
schaabs
reviewed
Jun 7, 2019
schaabs
reviewed
Jun 7, 2019
There was a problem hiding this comment.
Does it make sense to export these without the Async prefix, so that the same credential names can be used in both the sync and async?
Member
Author
There was a problem hiding this comment.
They could just have the same names, if we require a qualified import:
sync
from azure.identity import ClientSecretCredential
async
from azure.identity.aio import ClientSecretCredential
Which is fine by me. I followed the azure-core policy naming pattern here but I'm not attached to it.
rajivnandivada
pushed a commit
to rajivnandivada/azure-sdk-for-python
that referenced
this pull request
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5631:
SupportsGetTokenrenamedTokenCredentialDefaultAzureCredential, a chain of environment -> managed identity credentialsTokenCredentialChain.__init__takes credentials as variadic argumentsget_tokentakes scopes as variadic argumentsSome other changes:
ImdsCredentialandMsiCredentialto support both flavors of managed identityManagedIdentityCredentialbecomes a factory forImdsCredentialandMsiCredential. Its constructor returnsMsiCredentialif MSI environment variables are set,ImdsCredentialotherwise.Live tests (with recordings) and documentation updates are my next work items.