Key Vault clients use azure-identity credentials#5694
Merged
chlowell merged 16 commits intoAzure:masterfrom Jun 8, 2019
Merged
Key Vault clients use azure-identity credentials#5694chlowell merged 16 commits intoAzure:masterfrom
chlowell merged 16 commits intoAzure:masterfrom
Conversation
chlowell
added
KeyVault
Client
|
Can one of the admins verify this patch? |
chlowell
force-pushed
the
keyvault-identity
branch
from
3d4d843 to
f25486d
Compare
chlowell
force-pushed
the
keyvault-identity
branch
from
1189e4b to
06d513b
Compare
chlowell
force-pushed
the
keyvault-identity
branch
from
0a9b063 to
de410f6
Compare
schaabs
reviewed
Jun 7, 2019
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/vault_client.py
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Jun 7, 2019
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/aio/_internal.py
Outdated
Show resolved
Hide resolved
chlowell
force-pushed
the
keyvault-identity
branch
from
5d5338e to
94d2390
Compare
chlowell
force-pushed
the
keyvault-identity
branch
from
d256621 to
3a9dc8a
Compare
rajivnandivada
pushed a commit
to rajivnandivada/azure-sdk-for-python
that referenced
this pull request
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5551 and resolves #4877 by refactoring clients to share a common
__init__which acceptsazure-identitycredentials, builds a pipeline including the token auth policy fromazure-core, and allows specifying a Key Vault API version. The a/sync inits could be combined; I kept them separate in case we decide to spin off async packages.I also refactored
VaultClientPreparerto useazure-identity's environment credentials in live tests, and added a preparer and test case class for async tests.There are a few small miscellaneous fixes here as well, including one that closes #5604.
Work remains on the tests. The live tests are unreliable. Making them reliable requires larger changes I don't want to cram into this PR (tracked by #5693). Also, I replaced
ServicePrincipalCredentialsin examples withazure-identity'sClientSecretCredential, but examples should show the default credential instead. That doesn't exist yet, so it's also work for a future PR (tracked by #5006).