Skip to content

Packaging#5672

Merged
xiangyan99 merged 4 commits intomasterfrom
packaging
Jun 4, 2019
Merged

Packaging#5672
xiangyan99 merged 4 commits intomasterfrom
packaging

Conversation

@xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from lmazuel June 4, 2019 17:29
@xiangyan99 xiangyan99 requested a review from bryevdv as a code owner June 4, 2019 17:29
@adxsdk6
Copy link

adxsdk6 commented Jun 4, 2019

Can one of the admins verify this patch?

@xiangyan99 xiangyan99 requested a review from johanste June 4, 2019 18:13
package_name = "azure-core"
package_nspkg = "azure-nspkg"
package_pprint_name = "MyService Management"
package_pprint_name = "Core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_arm = false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the underline to fit, might make renderer upset otherwise

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with optional details to make it more perfect :)

@xiangyan99 xiangyan99 merged commit ed2eb26 into master Jun 4, 2019
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
* clean up the version and package name

* update setup.py

* update history and set is_arm to false
@xiangyan99 xiangyan99 deleted the packaging branch August 1, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments