Conversation
|
Can one of the admins verify this patch? |
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_client.py
Outdated
Show resolved
Hide resolved
| # type: (str, CertificatePolicy) -> CertificatePolicy | ||
| pass | ||
|
|
||
| def update_certificate(self, name, version, not_before=None, expires=None, enabled=None, tags=None, **kwargs): |
There was a problem hiding this comment.
Is not_before a boolean? Or is the #type annotation out-of-date?
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_client.py
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_models.py
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_models.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_models.py
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault/azure/security/keyvault/certificates/_models.py
Show resolved
Hide resolved
| issuer_id, | ||
| provider, | ||
| account_id, | ||
| password, |
There was a problem hiding this comment.
Are you certain none of these positional arguments could be optional? ("No, we can figure that out later" is a legitimate answer 😄)
There was a problem hiding this comment.
not certain -true.
Will update this as I work on the implementation if the client.
There was a problem hiding this comment.
You have to look at the documentation. In many cases, the openapi description of the API will indicate if the value is required or not. In some cases, the value is required under some circumstances (e.g. only when you create a resource), in which case it may not be explicitly specified as required in the openapi specification.
In this case, it doesn't look like many of the attributes are actually required.
Based on the design that we agreed upon and documented here - https://github.com/g2vinay/KVSpec/blob/master/Certsv4.md