Get successful mypy pass on azure core #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
xiangyan99
requested changes
May 24, 2019
| # -------------------------------------------------------------------------- | ||
| from typing import List, Union, Optional, TypeVar, Callable | ||
| from azure.core.pipeline.policies import AsyncHTTPPolicy, SansIOHTTPPolicy | ||
| from azure.core.exceptions import ( |
Member
There was a problem hiding this comment.
Do we need "try" for AsyncHTTPPolicy?
|
|
||
| def __init__(self, sender): | ||
| # type: (HttpTransport) -> None | ||
| # type: (Any) -> None |
Contributor
Author
There was a problem hiding this comment.
We had HTTPSender in msrest which we don't have anymore. Can't find a relevant sender class.
Member
There was a problem hiding this comment.
I think HttpTransport is correct
|
|
||
| def __init__(self, transport, policies=None): | ||
| # type: (HttpTransport, List[Union[HTTPPolicy, SansIOHTTPPolicy]]) -> None | ||
| # type: (Any, List[Union[HTTPPolicy, SansIOHTTPPolicy]]) -> None |
Member
There was a problem hiding this comment.
- transport is one kind of transport type, not any
- Shouldn't List[Union[HTTPPolicy, SansIOHTTPPolicy] be PoliciesType?
| @classmethod | ||
| def deserialize_from_text(cls, response, content_type=None): | ||
| # type: (Optional[Union[AnyStr, IO]], Optional[str]) -> Any | ||
| # type: (Optional[PipelineResponse], Optional[str]) -> Any |
Member
There was a problem hiding this comment.
Seems like we missed cls and response is not optional
| @classmethod | ||
| def deserialize_from_http_generics(cls, response): | ||
| # type: (Optional[Union[AnyStr, IO]], Mapping) -> Any | ||
| # type: (PipelineResponse) -> Any |
|
|
||
| def __init__(self, configuration=None, session=None, session_owner=True): | ||
| # type: (Optional[requests.Session]) -> None | ||
| # type: (Optional[Any], Optional[requests.Session], Any) -> None |
xiangyan99
reviewed
May 24, 2019
| from msrest.serialization import Model # type: ignore # pylint: disable=unused-import | ||
|
|
||
| AsyncHTTPResponseType = TypeVar("AsyncHTTPResponseType") | ||
| HTTPRequestType = TypeVar("HTTPRequestType") |
Member
There was a problem hiding this comment.
HTTPRequestType is already defined in sdk/core/azure-core/azure/core/pipeline/init.py
Member
There was a problem hiding this comment.
And seems like the only one uses AsyncHTTPResponseType & ImplPoliciesType is base_async.py
xiangyan99
reviewed
May 24, 2019
| from azure.core.pipeline.policies import AsyncHTTPPolicy, SansIOHTTPPolicy | ||
| from azure.core.common import ImplPoliciesType, PoliciesType | ||
|
|
||
| AsyncHTTPResponseType = TypeVar("AsyncHTTPResponseType") |
Member
There was a problem hiding this comment.
AsyncHTTPResponseType is already defined in azure.core.common
xiangyan99
reviewed
May 25, 2019
| return request.data | ||
|
|
||
| async def send(self, request: HttpRequest, **config: Any) -> AsyncHttpResponse: | ||
| async def send(self, request: HttpRequest, **config: Any) -> Optional[Any]: |
xiangyan99
reviewed
May 25, 2019
| # might provide our own implementation | ||
| from requests.structures import CaseInsensitiveDict | ||
| from azure.core.pipeline import ABC, AbstractContextManager | ||
| from azure.core.pipeline import ABC, AbstractContextManager, PipelineRequest, PipelineResponse |
Member
There was a problem hiding this comment.
Maybe we should use PipelineRequestType instead of import?
Can this change pass PyLint?
xiangyan99
reviewed
May 25, 2019
|
|
||
| def __init__(self, configuration=None, session=None, session_owner=True): | ||
| # type: (Optional[requests.Session]) -> None | ||
| # type: (Optional[Any], Optional[requests.Session], bool) -> None |
Member
There was a problem hiding this comment.
This is configuration type, not any
xiangyan99
reviewed
May 25, 2019
| Tuple, Callable, Iterator) | ||
|
|
||
| from azure.core.pipeline import ABC | ||
| from azure.core.pipeline import ABC, PipelineRequest, PipelineResponse |
Member
There was a problem hiding this comment.
Maybe we should use PipelineRequestType
xiangyan99
reviewed
May 25, 2019
|
|
||
| def __init__(self, http_request, http_response=None, error=None, context=None): | ||
| # type: (PipelineRequest[HTTPRequestType], Exception, Optional[Dict[str, Any]]) -> None | ||
| # type: (PipelineRequest, PipelineResponse, Exception, Optional[Dict[str, Any]]) -> None |
xiangyan99
reviewed
May 25, 2019
| """ | ||
| This module is the requests implementation of Pipeline ABC | ||
| """ | ||
| from azure.core.pipeline import PipelineRequest, PipelineResponse |
xiangyan99
approved these changes
May 25, 2019
azure-sdk
pushed a commit
that referenced
this pull request
Feb 21, 2023
azure-sdk
added a commit
that referenced
this pull request
Feb 21, 2023
…5456 (#28923) Co-authored-by: Mike Harder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #5266
Resolves #5022