Fix cosmos CI build failures caused by dev_setup.py changes#5310
Merged
scbedd merged 3 commits intoAzure:masterfrom May 20, 2019
Merged
Fix cosmos CI build failures caused by dev_setup.py changes#5310scbedd merged 3 commits intoAzure:masterfrom
scbedd merged 3 commits intoAzure:masterfrom
Conversation
|
Can one of the admins verify this patch? |
bryevdv
approved these changes
May 20, 2019
Contributor
|
@scbedd actually, are the Cosmos emulator tests running here? I don't seem to see them in the output above but maybe I am missing something? |
Member
Author
Yep, needed to update the |
xiangyan99
added a commit
that referenced
this pull request
May 20, 2019
* add missing import (#5340) * Fix cosmos CI build failures caused by dev_setup.py changes (#5310) * fixing pipeline issues caused by changes to dev_setup. both in standard and nightly tests. * Adds a event hubs PR pipeline YAML. (#5297) * [AutoPR] hanaonazure/resource-manager (#5275) * Generated from 5c4ec331dfcb15ae3c469ab9fba625800df0dded (#5165) Added new SKUs * Move HanaOnAzure to SDK folder * Generated from 5e0b04675163b24ef5fd29c3455d0bb121e4465b (#5343) Hanaonazure on SDK folder * ChangeLog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change! From here on out will grep
dev_setup.pythrough the repo on any change to the input strategy. This kind of thing shouldn't happen again.