Skip to content

azure-identity prototype#5246

Merged
chlowell merged 9 commits intoAzure:masterfrom
chlowell:identity-prototype
May 29, 2019
Merged

azure-identity prototype#5246
chlowell merged 9 commits intoAzure:masterfrom
chlowell:identity-prototype

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented May 15, 2019

This includes just Async/ClientSecretCredential, which should suffice to unblock development scenarios.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 15, 2019
@chlowell chlowell requested a review from schaabs May 15, 2019 18:03
@adxsdk6
Copy link

adxsdk6 commented May 15, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented May 15, 2019

Can one of the admins verify this patch?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class should eventually support both client secret auth, and certificate auth, so using ClientSecretTokenProvider as a base probably won't work long term.

@chlowell
Copy link
Member Author

@scbedd does this belong under /sdk/core?

@scbedd
Copy link
Member

scbedd commented May 21, 2019

@scbedd does this belong under /sdk/core?

I haven't heard much context on this. I will follow up with Scott in the morning to get that if you don't respond before then.

Is this a shared scenario? If so, it goes under core/. Does it map to a service? Aka: Azure Active Directory or the like?

@chlowell
Copy link
Member Author

I see the .NET equivalent is under /sdk/identity. I'll use that path here as well.

@chlowell chlowell force-pushed the identity-prototype branch from 89247cd to 5fe9e64 Compare May 21, 2019 13:08
@chlowell chlowell marked this pull request as ready for review May 21, 2019 14:32
@chlowell chlowell requested a review from lmazuel as a code owner May 21, 2019 14:32
@chlowell chlowell requested a review from YijunXieMS May 21, 2019 14:33
@codecov-io
Copy link

Codecov Report

Merging #5246 into master will decrease coverage by 3.86%.
The diff coverage is 84.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
- Coverage   52.26%   48.39%   -3.87%     
==========================================
  Files       10893     6564    -4329     
  Lines      233821   188861   -44960     
==========================================
- Hits       122203    91400   -30803     
+ Misses     111618    97461   -14157
Impacted Files Coverage Δ
.../azure-identity/azure/identity/aio/authn_client.py 100% <100%> (ø)
...tity/azure-identity/azure/identity/aio/__init__.py 100% <100%> (ø)
...identity/azure-identity/azure/identity/__init__.py 75% <75%> (ø)
...ntity/azure-identity/azure/identity/credentials.py 77.19% <77.19%> (ø)
...entity/azure-identity/azure/identity/exceptions.py 80% <80%> (ø)
...tity/azure-identity/azure/identity/authn_client.py 83.33% <83.33%> (ø)
...y/azure-identity/azure/identity/aio/credentials.py 87.5% <87.5%> (ø)
...afactory/azure/mgmt/datafactory/models/__init__.py 50.67% <0%> (-49.33%) ⬇️
...ights/azure/applicationinsights/models/__init__.py 51% <0%> (-49%) ⬇️
...e/cognitiveservices/vision/face/models/__init__.py 51.08% <0%> (-48.92%) ⬇️
... and 4453 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2ae38...2207b64. Read the comment docs.

@chlowell chlowell requested a review from yugangw-msft May 28, 2019 15:47
@chlowell chlowell force-pushed the identity-prototype branch from 0eb2964 to 9515f15 Compare May 28, 2019 22:53
@chlowell chlowell force-pushed the identity-prototype branch from 9515f15 to 08c8094 Compare May 29, 2019 14:37
@chlowell
Copy link
Member Author

/azp run azure-sdk-for-python - client

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chlowell chlowell merged commit b33ec2b into Azure:master May 29, 2019
@chlowell chlowell deleted the identity-prototype branch May 29, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants