-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Key Vault track 2 package stubs #5143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
0eee443 to
d66e26e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5143 +/- ##
=======================================
Coverage 49.5% 49.5%
=======================================
Files 6274 6274
Lines 173320 173320
=======================================
Hits 85804 85804
Misses 87516 87516Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a single distribution package,
azure-security-keyvault. This is partly kicking the can but I like it as a reasonable first step that gets us working on master. I expect spinning off packages to be simpler than merging them, especially if we've shipped a preview, andazure-security-keyvaultcan continue as a metapackage after being decomposed.Closes #4632