Skip to content

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented May 8, 2019

This creates a single distribution package, azure-security-keyvault. This is partly kicking the can but I like it as a reasonable first step that gets us working on master. I expect spinning off packages to be simpler than merging them, especially if we've shipped a preview, and azure-security-keyvault can continue as a metapackage after being decomposed.

Closes #4632

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels May 8, 2019
@chlowell chlowell requested a review from schaabs May 8, 2019 02:37
@adxsdk6
Copy link

adxsdk6 commented May 8, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented May 8, 2019

Can one of the admins verify this patch?

@chlowell chlowell force-pushed the keyvault-packages branch from 0eee443 to d66e26e Compare May 9, 2019 13:17
@chlowell chlowell requested a review from johanste May 9, 2019 13:20
@chlowell chlowell marked this pull request as ready for review May 9, 2019 19:52
@chlowell chlowell requested a review from lmazuel as a code owner May 9, 2019 19:52
@codecov-io
Copy link

Codecov Report

Merging #5143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5143   +/-   ##
=======================================
  Coverage    49.5%    49.5%           
=======================================
  Files        6274     6274           
  Lines      173320   173320           
=======================================
  Hits        85804    85804           
  Misses      87516    87516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bed2b...82b7dfd. Read the comment docs.

@chlowell chlowell merged commit 88113df into Azure:master May 14, 2019
@chlowell chlowell deleted the keyvault-packages branch May 14, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package track 2 clients

3 participants