Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14353 #45530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chidozieononiwu merged 2 commits into from
Mar 5, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14353 #45530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad1d212
Add setting the registry in the npmrc
chidozieononiwu Mar 5, 2026
7dff22d
Check for errors
chidozieononiwu Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions eng/common/pipelines/templates/jobs/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,9 @@ jobs:
- ${{ if eq(parameters.Registry, 'https://registry.npmjs.org/') }}:

- task: PowerShell@2
displayName: 'Delete repo .npmrc'
condition: and(succeeded(), ne(variables['SkipPublishing'], 'true'))
inputs:
targetType: inline
script: |
$npmrcPath = "$(System.DefaultWorkingDirectory)/.npmrc"
if (Test-Path $npmrcPath) {
Remove-Item -Path $npmrcPath -Force
Write-Host "Deleted $npmrcPath to use default npmjs registry."
} else {
Write-Host "No repo .npmrc found at $npmrcPath."
}
pwsh: true
- template: /eng/common/pipelines/templates/steps/reset-npmrc.yml
parameters:
Registry: ${{ parameters.Registry }}

- task: EsrpRelease@9
displayName: 'Publish ${{ parameters.ArtifactName }} via ESRP'
Expand Down
32 changes: 32 additions & 0 deletions eng/common/pipelines/templates/steps/reset-npmrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
parameters:
Registry: 'https://registry.npmjs.org/'

steps:
- task: PowerShell@2
displayName: 'Set project npm registry'
inputs:
targetType: inline
script: |
$ErrorActionPreference = 'Stop'

Write-Host "Registry before update:"
npm config get registry --location=project
if ($LASTEXITCODE -ne 0) {
throw "Failed to read current project npm registry."
}

npm config set registry "${{ parameters.Registry }}" --location=project
if ($LASTEXITCODE -ne 0) {
throw "Failed to set project npm registry to '${{ parameters.Registry }}'."
}

Write-Host "Registry after update:"
$updatedRegistry = npm config get registry --location=project
if ($LASTEXITCODE -ne 0) {
throw "Failed to read updated project npm registry."
}

if ($updatedRegistry.Trim() -ne "${{ parameters.Registry }}") {
throw "Project npm registry mismatch. Expected '${{ parameters.Registry }}' but got '$updatedRegistry'."
}
pwsh: true
Comment on lines +5 to +32
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old "Delete repo .npmrc" step had condition: and(succeeded(), ne(variables['SkipPublishing'], 'true')), meaning it was skipped when no packages were found (SkipPublishing set to true). The new reset-npmrc.yml template exposes no condition parameter, and the call site in npm-publish.yml does not set one either — so the registry reset step will now run unconditionally even when SkipPublishing is true. This is inconsistent with the EsrpRelease@9 step immediately following it (which retains the SkipPublishing condition check). Consider either adding a CustomCondition parameter to reset-npmrc.yml (following the pattern in create-authenticated-npmrc.yml) or adding condition: and(succeeded(), ne(variables['SkipPublishing'], 'true')) to the template step directly.

Copilot uses AI. Check for mistakes.
Loading