[AutoPR azure-mgmt-containerservicefleet]-generated-from-SDK Generation - Python-5926809#45369
Draft
azure-sdk wants to merge 1 commit intoAzure:mainfrom
Draft
Conversation
…osoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926809 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the azure-mgmt-containerservicefleet (beta) SDK generated from the 2025-08-01-preview TypeSpec source, aligning the package with the latest swagger/spec commit and generator output.
Changes:
- Bumps package version to
4.0.0b3and updates metadata/source pointers to the new TypeSpec location + commit. - Adds optional paging/filter query parameters (
top,skip_token,filter) to several list operations (sync + async). - Regenerates supporting model/enum/utilities code and adds a new generated sample for FleetManagedNamespaces update.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/containerservice/azure-mgmt-containerservicefleet/tsp-location.yaml | Updates TypeSpec source directory + spec commit reference. |
| sdk/containerservice/azure-mgmt-containerservicefleet/generated_samples/fleet_managed_namespaces_update.py | Adds a generated sample for updating a FleetManagedNamespace. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/operations/_patch.py | Updates patch scaffolding typing annotation style. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/operations/_operations.py | Adds top/skip_token/filter parameters to list operations and wires them into request builders + docstrings. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/models/_patch.py | Updates patch scaffolding typing annotation style. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/models/_models.py | Regenerates model docstrings and adds original_tsp_name in select fields. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/models/_enums.py | Regenerates enums; includes a rename of the LabelSelectorOperator member for "In". |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/operations/_patch.py | Updates patch scaffolding typing annotation style (async ops). |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/operations/_operations.py | Async equivalents of the new list parameters and request wiring. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/_patch.py | Updates patch scaffolding typing annotation style (async package). |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/_configuration.py | Updates api_version docstring text for the async configuration. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/_client.py | Updates api_version docstring text for the async client. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_version.py | Bumps version from 4.0.0b2 to 4.0.0b3. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_utils/serialization.py | Removes eval usage for basic type conversion and improves error messaging. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_utils/model_base.py | Regenerates model base utilities (serialization/deserialization helpers, rest_field additions). |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_patch.py | Updates patch scaffolding typing annotation style (sync package). |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_configuration.py | Updates api_version docstring text for the sync configuration. |
| sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/_client.py | Updates api_version docstring text for the sync client. |
| sdk/containerservice/azure-mgmt-containerservicefleet/_metadata.json | Updates generator metadata (apiVersions shape, commit SHA, emitter version, typespec_src). |
| sdk/containerservice/azure-mgmt-containerservicefleet/CHANGELOG.md | Adds 4.0.0b3 entry documenting new parameters and the enum breaking change. |
Comment on lines
+190
to
+191
| INEnum = "In" | ||
| """Label Selector Operator In.""" |
There was a problem hiding this comment.
LabelSelectorOperator renames the existing IN enum member to INEnum, which is both a breaking change and inconsistent with the naming pattern used by the other members (NOT_IN, EXISTS, etc.). Consider restoring IN (or adding IN as an alias to INEnum) to preserve back-compat while keeping the generated name if needed, and update the changelog accordingly.
Suggested change
| INEnum = "In" | |
| """Label Selector Operator In.""" | |
| IN = "In" | |
| """Label Selector Operator In.""" | |
| INEnum = "In" |
Comment on lines
+2571
to
+2581
| :ivar name: The skip target's name. To skip a member/group/stage, use the member/group/stage's | ||
| name; Tp skip an after stage wait, use the parent stage's name. Required. | ||
| :vartype name: str | ||
| """ | ||
|
|
||
| type: Union[str, "_models.TargetType"] = rest_field(visibility=["read", "create", "update", "delete", "query"]) | ||
| """The skip target type. Required. Known values are: \"Member\", \"Group\", \"Stage\", and | ||
| \"AfterStageWait\".""" | ||
| name: str = rest_field(visibility=["read", "create", "update", "delete", "query"]) | ||
| """The skip target's name. | ||
| To skip a member/group/stage, use the member/group/stage's name; | ||
| Tp skip an after stage wait, use the parent stage's name. Required.""" | ||
| """The skip target's name. To skip a member/group/stage, use the member/group/stage's name; Tp | ||
| skip an after stage wait, use the parent stage's name. Required.""" |
There was a problem hiding this comment.
Typo in docstrings: "Tp skip" should be "To skip" (appears in both the class docstring and the field docstring).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926809 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=fd5c7709-d7cf-f011-bbd3-6045bd07ef68 Submitted by: ryan.zhang@microsoft.com
Release Plan Details
Spec pull request: Add 2025-08-01-preview azure-rest-api-specs#38919
Spec API version: 2025-08-01-preview