Skip to content

[auto release pipeline] Skip release pipeline comment when link is empty #45032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 2 commits into from
Feb 5, 2026
Merged

[auto release pipeline] Skip release pipeline comment when link is empty #45032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8032d25
Skip release pipeline comment when link is empty
msyyc Feb 5, 2026
c0b34fc
Merge branch 'main' into bump-typespec-python-0.60.0
msyyc Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/auto_release/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,11 @@ def create_pr_proc(self):
pr_title = "[AutoRelease] {}(can only be merged by SDK owner)".format(self.new_branch)
pr_head = "{}:{}".format(os.getenv("USR_NAME"), self.new_branch)
pr_base = "main"
pr_body = "{} \n{} \n After PR merged, trigger [release pipeline]({}) to release".format(
self.issue_link, self.test_result, self.release_pipeline_link
)
pr_body = "PR for release issue {}".format(self.issue_link)
if self.release_pipeline_link:
pr_body += " \n After PR merged, trigger [release pipeline]({}) to release".format(
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space before the newline character (" \n") is inconsistent with the pattern used elsewhere in this method (lines 338-339 use "\n" without a space). Consider using "\n" instead of " \n" for consistency.

Suggested change
pr_body += " \n After PR merged, trigger [release pipeline]({}) to release".format(
pr_body += "\n After PR merged, trigger [release pipeline]({}) to release".format(

Copilot uses AI. Check for mistakes.
self.release_pipeline_link
)
if self.has_multi_packages:
pr_body += f"\nBuildTargetingString\n {self.whole_package_name}\nSkip.CreateApiReview"
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test result information (self.test_result) was removed from the PR body during the refactoring. The original code included both self.issue_link and self.test_result in the PR body. The test result contains important information about whether tests passed or failed (e.g., "Live test success" or "Recording test fail"). This information should be preserved in the new PR body format to maintain the same functionality.

Suggested change
pr_body += f"\nBuildTargetingString\n {self.whole_package_name}\nSkip.CreateApiReview"
pr_body += f"\nBuildTargetingString\n {self.whole_package_name}\nSkip.CreateApiReview"
test_result = getattr(self, "test_result", None)
if test_result:
pr_body += "\n\nTest result: {}".format(test_result)

Copilot uses AI. Check for mistakes.
pr_body += "\n\n (Just to record: this PR was created by this [pipeline]({}))".format(
Expand Down
Loading